svn merge -c 1402608 from trunk for HDFS-3616. Fix a ConcurrentModificationException bug that BP actor threads
may not be shutdown properly in DataNode. git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-2@1402609 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
parent
d1c730d716
commit
7692aa392b
|
@ -158,6 +158,9 @@ Release 2.0.3-alpha - Unreleased
|
|||
out stream returned by WebHdfsFileSystem does not support it. (Jing Zhao
|
||||
via szetszwo)
|
||||
|
||||
HDFS-3616. Fix a ConcurrentModificationException bug that BP actor threads
|
||||
may not be shutdown properly in DataNode. (Jing Zhao via szetszwo)
|
||||
|
||||
Release 2.0.2-alpha - 2012-09-07
|
||||
|
||||
INCOMPATIBLE CHANGES
|
||||
|
|
|
@ -106,15 +106,15 @@ class BlockPoolManager {
|
|||
}
|
||||
}
|
||||
|
||||
void shutDownAll() throws InterruptedException {
|
||||
BPOfferService[] bposArray = this.getAllNamenodeThreads();
|
||||
|
||||
for (BPOfferService bpos : bposArray) {
|
||||
bpos.stop(); //interrupts the threads
|
||||
}
|
||||
//now join
|
||||
for (BPOfferService bpos : bposArray) {
|
||||
bpos.join();
|
||||
void shutDownAll(BPOfferService[] bposArray) throws InterruptedException {
|
||||
if (bposArray != null) {
|
||||
for (BPOfferService bpos : bposArray) {
|
||||
bpos.stop(); //interrupts the threads
|
||||
}
|
||||
//now join
|
||||
for (BPOfferService bpos : bposArray) {
|
||||
bpos.join();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -1095,6 +1095,12 @@ public class DataNode extends Configured
|
|||
}
|
||||
}
|
||||
|
||||
// We need to make a copy of the original blockPoolManager#offerServices to
|
||||
// make sure blockPoolManager#shutDownAll() can still access all the
|
||||
// BPOfferServices, since after setting DataNode#shouldRun to false the
|
||||
// offerServices may be modified.
|
||||
BPOfferService[] bposArray = this.blockPoolManager == null ? null
|
||||
: this.blockPoolManager.getAllNamenodeThreads();
|
||||
this.shouldRun = false;
|
||||
shutdownPeriodicScanners();
|
||||
|
||||
|
@ -1141,7 +1147,7 @@ public class DataNode extends Configured
|
|||
|
||||
if(blockPoolManager != null) {
|
||||
try {
|
||||
this.blockPoolManager.shutDownAll();
|
||||
this.blockPoolManager.shutDownAll(bposArray);
|
||||
} catch (InterruptedException ie) {
|
||||
LOG.warn("Received exception in BlockPoolManager#shutDownAll: ", ie);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue