diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index 65324958d7d..4979c247971 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -88,6 +88,9 @@ Release 2.3.0 - UNRELEASED HADOOP-9594. Update apache commons math dependency (Timothy St. Clair via stevel) + HADOOP-10095. In CodecPool, synchronize pool and codecList separately in + order to reduce lock contention. (Nicolas Liochon via szetszwo) + OPTIMIZATIONS HADOOP-9748. Reduce blocking on UGI.ensureInitialized (daryn) diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CodecPool.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CodecPool.java index 63e3a09c307..11d88f13cd4 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CodecPool.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CodecPool.java @@ -85,16 +85,15 @@ public class CodecPool { T codec = null; // Check if an appropriate codec is available + List codecList; synchronized (pool) { - if (pool.containsKey(codecClass)) { - List codecList = pool.get(codecClass); - - if (codecList != null) { - synchronized (codecList) { - if (!codecList.isEmpty()) { - codec = codecList.remove(codecList.size()-1); - } - } + codecList = pool.get(codecClass); + } + + if (codecList != null) { + synchronized (codecList) { + if (!codecList.isEmpty()) { + codec = codecList.remove(codecList.size() - 1); } } } @@ -105,15 +104,17 @@ public class CodecPool { private static void payback(Map, List> pool, T codec) { if (codec != null) { Class codecClass = ReflectionUtils.getClass(codec); + List codecList; synchronized (pool) { - if (!pool.containsKey(codecClass)) { - pool.put(codecClass, new ArrayList()); + codecList = pool.get(codecClass); + if (codecList == null) { + codecList = new ArrayList(); + pool.put(codecClass, codecList); } + } - List codecList = pool.get(codecClass); - synchronized (codecList) { - codecList.add(codec); - } + synchronized (codecList) { + codecList.add(codec); } } }