HADOOP-18476. Abfs and S3A FileContext bindings to close wrapped filesystems in finalizer (#4966)

This is to try and close the underlying filesystems when the FileContext APIs are used.
Without this, threads may be leaked

Contributed by Steve Loughran
This commit is contained in:
Steve Loughran 2022-10-18 14:53:02 +01:00
parent 84c7fd909b
commit 7a18ceb269
No known key found for this signature in database
GPG Key ID: D22CF846DBB162A0
3 changed files with 29 additions and 2 deletions

View File

@ -33,7 +33,7 @@ import java.net.URISyntaxException;
*/ */
@InterfaceAudience.Public @InterfaceAudience.Public
@InterfaceStability.Evolving @InterfaceStability.Evolving
public class S3A extends DelegateToFileSystem{ public class S3A extends DelegateToFileSystem {
public S3A(URI theUri, Configuration conf) public S3A(URI theUri, Configuration conf)
throws IOException, URISyntaxException { throws IOException, URISyntaxException {
@ -54,4 +54,13 @@ public class S3A extends DelegateToFileSystem{
sb.append('}'); sb.append('}');
return sb.toString(); return sb.toString();
} }
/**
* Close the file system; the FileContext API doesn't have an explicit close.
*/
@Override
protected void finalize() throws Throwable {
fsImpl.close();
super.finalize();
}
} }

View File

@ -43,4 +43,13 @@ public class Abfs extends DelegateToFileSystem {
public int getUriDefaultPort() { public int getUriDefaultPort() {
return -1; return -1;
} }
/**
* Close the file system; the FileContext API doesn't have an explicit close.
*/
@Override
protected void finalize() throws Throwable {
fsImpl.close();
super.finalize();
}
} }

View File

@ -43,4 +43,13 @@ public class Abfss extends DelegateToFileSystem {
public int getUriDefaultPort() { public int getUriDefaultPort() {
return -1; return -1;
} }
/**
* Close the file system; the FileContext API doesn't have an explicit close.
*/
@Override
protected void finalize() throws Throwable {
fsImpl.close();
super.finalize();
}
} }