Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HADOOP-8244. Improve comments on ByteBufferReadable.read. Contributed by Henry Robinson. 

(svn merge -c 1309625 from trunk)


git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-2@1348209 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Todd Lipcon 2012-06-08 19:54:42 +00:00
parent e3721d582c
commit 7b743ac87f
2 changed files with 19 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-common-project/hadoop-common/CHANGES.txt
View File

@ -34,6 +34,9 @@ Release 2.0.1-alpha - UNRELEASED
HADOOP-8358. Config-related WARN for dfs.web.ugi can be avoided. (harsh) HADOOP-8358. Config-related WARN for dfs.web.ugi can be avoided. (harsh)
HADOOP-8244. Improve comments on ByteBufferReadable.read. (Henry Robinson
via atm)
BUG FIXES BUG FIXES
HADOOP-8372. NetUtils.normalizeHostName() incorrectly handles hostname HADOOP-8372. NetUtils.normalizeHostName() incorrectly handles hostname

22
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ByteBufferReadable.java
View File

@ -28,18 +28,28 @@ public interface ByteBufferReadable {
/** /**
* Reads up to buf.remaining() bytes into buf. Callers should use * Reads up to buf.remaining() bytes into buf. Callers should use
* buf.limit(..) to control the size of the desired read. * buf.limit(..) to control the size of the desired read.
* * <p/>
* After the call, buf.position() should be unchanged, and therefore any data * After a successful call, buf.position() and buf.limit() should be
* can be immediately read from buf. * unchanged, and therefore any data can be immediately read from buf.
* * buf.mark() may be cleared or updated.
* <p/>
* In the case of an exception, the values of buf.position() and buf.limit()
* are undefined, and callers should be prepared to recover from this
* eventuality.
* <p/>
* Many implementations will throw {@link UnsupportedOperationException}, so * Many implementations will throw {@link UnsupportedOperationException}, so
* callers that are not confident in support for this method from the * callers that are not confident in support for this method from the
* underlying filesystem should be prepared to handle that exception. * underlying filesystem should be prepared to handle that exception.
* <p/>
* Implementations should treat 0-length requests as legitimate, and must not
* signal an error upon their receipt.
* *
* @param buf * @param buf
* the ByteBuffer to receive the results of the read operation * the ByteBuffer to receive the results of the read operation. Up to
* buf.limit() - buf.position() bytes may be read.
* @return the number of bytes available to read from buf * @return the number of bytes available to read from buf
* @throws IOException if there is some error performing the read * @throws IOException
* if there is some error performing the read
*/ */
public int read(ByteBuffer buf) throws IOException; public int read(ByteBuffer buf) throws IOException;
} }