Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MAPREDUCE-7303. Fix TestJobResourceUploader failures after HADOOP-16878. Contributed by Peter Bacsko.

This commit is contained in:
Akira Ajisaka 2020-10-23 04:34:49 +09:00
parent 6ea2731c2b
commit 7bc305db5d
No known key found for this signature in database
GPG Key ID: C1EDBB9CA400FD50
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/TestJobResourceUploader.java
View File

@ -399,6 +399,7 @@ public class TestJobResourceUploader {
Path expectedRemotePath) throws IOException, URISyntaxException { Path expectedRemotePath) throws IOException, URISyntaxException {
Path dstPath = new Path("hdfs://localhost:1234/home/hadoop/"); Path dstPath = new Path("hdfs://localhost:1234/home/hadoop/");
DistributedFileSystem fs = mock(DistributedFileSystem.class); DistributedFileSystem fs = mock(DistributedFileSystem.class);
when(fs.makeQualified(any(Path.class))).thenReturn(dstPath);
// make sure that FileUtils.copy() doesn't try to copy anything // make sure that FileUtils.copy() doesn't try to copy anything
when(fs.mkdirs(any(Path.class))).thenReturn(false); when(fs.mkdirs(any(Path.class))).thenReturn(false);
when(fs.getUri()).thenReturn(dstPath.toUri()); when(fs.getUri()).thenReturn(dstPath.toUri());
@ -407,6 +408,7 @@ public class TestJobResourceUploader {
JobConf jConf = new JobConf(); JobConf jConf = new JobConf();
Path originalPath = spy(path); Path originalPath = spy(path);
FileSystem localFs = mock(FileSystem.class); FileSystem localFs = mock(FileSystem.class);
when(localFs.makeQualified(any(Path.class))).thenReturn(path);
FileStatus fileStatus = mock(FileStatus.class); FileStatus fileStatus = mock(FileStatus.class);
when(localFs.getFileStatus(any(Path.class))).thenReturn(fileStatus); when(localFs.getFileStatus(any(Path.class))).thenReturn(fileStatus);
when(fileStatus.isDirectory()).thenReturn(true); when(fileStatus.isDirectory()).thenReturn(true);
@ -420,8 +422,14 @@ public class TestJobResourceUploader {
originalPath, jConf, (short) 1); originalPath, jConf, (short) 1);
ArgumentCaptor<Path> pathCaptor = ArgumentCaptor.forClass(Path.class); ArgumentCaptor<Path> pathCaptor = ArgumentCaptor.forClass(Path.class);
verify(fs).makeQualified(pathCaptor.capture()); verify(fs, times(2)).makeQualified(pathCaptor.capture());
Assert.assertEquals("Path", expectedRemotePath, pathCaptor.getValue()); List<Path> paths = pathCaptor.getAllValues();
// first call is invoked on a path which was created by the test,
// but the second one is created in copyRemoteFiles()
Assert.assertEquals("Expected remote path",
expectedRemotePath, paths.get(0));
Assert.assertEquals("Expected remote path",
expectedRemotePath, paths.get(1));
} }
private void testErasureCodingSetting(boolean defaultBehavior) private void testErasureCodingSetting(boolean defaultBehavior)