Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

YARN-161. Fix multiple compiler warnings for unchecked operations in YARN common. Contributed by Chris Nauroth. 

svn merge --ignore-ancestry -c 1399056 ../../trunk/


git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-2@1399057 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Vinod Kumar Vavilapalli 2012-10-17 00:32:37 +00:00
parent bd6c745418
commit 7c550ccb09
5 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-yarn-project/CHANGES.txt
View File

@ -127,6 +127,9 @@ Release 0.23.5 - UNRELEASED
IMPROVEMENTS
YARN-161. Fix multiple compiler warnings for unchecked operations in YARN
common. (Chris Nauroth via vinodkv)
OPTIMIZATIONS
BUG FIXES

2
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/RecordFactoryProvider.java
View File

@ -58,7 +58,7 @@ public static RecordFactory getRecordFactory(Configuration conf) {
private static Object getFactoryClassInstance(String factoryClassName) {
try {
Class clazz = Class.forName(factoryClassName);
Class<?> clazz = Class.forName(factoryClassName);
Method method = clazz.getMethod("get", null);
method.setAccessible(true);
return method.invoke(null, null);

2
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/RpcFactoryProvider.java
View File

@ -73,7 +73,7 @@ public static RpcClientFactory getClientFactory(Configuration conf) {
private static Object getFactoryClassInstance(String factoryClassName) {
try {
Class clazz = Class.forName(factoryClassName);
Class<?> clazz = Class.forName(factoryClassName);
Method method = clazz.getMethod("get", null);
method.setAccessible(true);
return method.invoke(null, null);

2
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/YarnRemoteExceptionFactoryProvider.java
View File

@ -51,7 +51,7 @@ public static YarnRemoteExceptionFactory getYarnRemoteExceptionFactory(Configura
private static Object getFactoryClassInstance(String factoryClassName) {
try {
Class clazz = Class.forName(factoryClassName);
Class<?> clazz = Class.forName(factoryClassName);
Method method = clazz.getMethod("get", null);
method.setAccessible(true);
return method.invoke(null, null);

22
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/StateMachineFactory.java
View File

@ -68,7 +68,7 @@ public StateMachineFactory(STATE defaultInitialState) {
private StateMachineFactory
(StateMachineFactory<OPERAND, STATE, EVENTTYPE, EVENT> that,
ApplicableTransition t) {
ApplicableTransition<OPERAND, STATE, EVENTTYPE, EVENT> t) {
this.defaultInitialState = that.defaultInitialState;
this.transitionsListNode
= new TransitionsListNode(t, that.transitionsListNode);
@ -96,11 +96,12 @@ private interface ApplicableTransition
}
private class TransitionsListNode {
final ApplicableTransition transition;
final ApplicableTransition<OPERAND, STATE, EVENTTYPE, EVENT> transition;
final TransitionsListNode next;
TransitionsListNode
(ApplicableTransition transition, TransitionsListNode next) {
(ApplicableTransition<OPERAND, STATE, EVENTTYPE, EVENT> transition,
TransitionsListNode next) {
this.transition = transition;
this.next = next;
}
@ -225,8 +226,8 @@ public StateMachineFactory<OPERAND, STATE, EVENTTYPE, EVENT> addTransition(
addTransition(STATE preState, STATE postState,
EVENTTYPE eventType,
SingleArcTransition<OPERAND, EVENT> hook){
return new StateMachineFactory
(this, new ApplicableSingleOrMultipleTransition
return new StateMachineFactory<OPERAND, STATE, EVENTTYPE, EVENT>
(this, new ApplicableSingleOrMultipleTransition<OPERAND, STATE, EVENTTYPE, EVENT>
(preState, eventType, new SingleInternalArc(postState, hook)));
}
@ -248,9 +249,9 @@ public StateMachineFactory<OPERAND, STATE, EVENTTYPE, EVENT> addTransition(
addTransition(STATE preState, Set<STATE> postStates,
EVENTTYPE eventType,
MultipleArcTransition<OPERAND, EVENT, STATE> hook){
return new StateMachineFactory
return new StateMachineFactory<OPERAND, STATE, EVENTTYPE, EVENT>
(this,
new ApplicableSingleOrMultipleTransition
new ApplicableSingleOrMultipleTransition<OPERAND, STATE, EVENTTYPE, EVENT>
(preState, eventType, new MultipleInternalArc(postStates, hook)));
}
@ -273,7 +274,7 @@ public StateMachineFactory<OPERAND, STATE, EVENTTYPE, EVENT> addTransition(
public StateMachineFactory
<OPERAND, STATE, EVENTTYPE, EVENT>
installTopology() {
return new StateMachineFactory(this, true);
return new StateMachineFactory<OPERAND, STATE, EVENTTYPE, EVENT>(this, true);
}
/**
@ -308,7 +309,8 @@ private synchronized void maybeMakeStateMachineTable() {
}
private void makeStateMachineTable() {
Stack<ApplicableTransition> stack = new Stack<ApplicableTransition>();
Stack<ApplicableTransition<OPERAND, STATE, EVENTTYPE, EVENT>> stack =
new Stack<ApplicableTransition<OPERAND, STATE, EVENTTYPE, EVENT>>();
Map<STATE, Map<EVENTTYPE, Transition<OPERAND, STATE, EVENTTYPE, EVENT>>>
prototype = new HashMap<STATE, Map<EVENTTYPE, Transition<OPERAND, STATE, EVENTTYPE, EVENT>>>();
@ -469,7 +471,7 @@ public Graph generateStateGraph(String name) {
} else if (transition instanceof StateMachineFactory.MultipleInternalArc) {
StateMachineFactory.MultipleInternalArc ma
= (StateMachineFactory.MultipleInternalArc) transition;
Iterator<STATE> iter = ma.validPostStates.iterator();
Iterator iter = ma.validPostStates.iterator();
while (iter.hasNext()) {
Graph.Node fromNode = g.getNode(startState.toString());
Graph.Node toNode = g.getNode(iter.next().toString());