Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HADOOP-13756 LocalMetadataStore#put(DirListingMetadata) should also put file metadata into fileHash. (Gabor Bota)

This commit is contained in:
Aaron Fabbri 2018-04-26 20:40:30 -07:00
parent 0a293de00d
commit 7d8bcf534a
No known key found for this signature in database
GPG Key ID: B2EEFA9E78118A29
2 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/LocalMetadataStore.java
View File

@ -281,6 +281,7 @@ public class LocalMetadataStore implements MetadataStore {
LOG.debug("put dirMeta {}", meta.prettyPrint()); LOG.debug("put dirMeta {}", meta.prettyPrint());
} }
dirHash.put(standardize(meta.getPath()), meta); dirHash.put(standardize(meta.getPath()), meta);
put(meta.getListing());
} }
public synchronized void put(Collection<PathMetadata> metas) throws public synchronized void put(Collection<PathMetadata> metas) throws

27
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/MetadataStoreTestBase.java
View File

@ -738,6 +738,33 @@ public abstract class MetadataStoreTestBase extends Assert {
} }
} }
@Test
public void testPutDirListingMetadataPutsFileMetadata()
throws IOException {
boolean authoritative = true;
String[] filenames = {"/dir1/file1", "/dir1/file2", "/dir1/file3"};
String dirPath = "/dir1";
ArrayList<PathMetadata> metas = new ArrayList<>(filenames.length);
for (String filename : filenames) {
metas.add(new PathMetadata(makeFileStatus(filename, 100)));
}
DirListingMetadata dirMeta =
new DirListingMetadata(strToPath(dirPath), metas, authoritative);
ms.put(dirMeta);
if (!allowMissing()) {
assertDirectorySize(dirPath, filenames.length);
PathMetadata metadata;
for(String fileName : filenames){
metadata = ms.get(strToPath(fileName));
assertNotNull(String.format(
"PathMetadata for file %s should not be null.", fileName),
metadata);
}
}
}
/* /*
* Helper functions. * Helper functions.
*/ */