Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-13217. Audit log all EC policy names during addErasureCodingPolicies. Contributed by liaoyuxiangqin.

This commit is contained in:
Xiao Chen 2018-08-15 09:22:24 -07:00 committed by Arpit Agarwal
parent c15853f87a
commit 81fbfe500e
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
View File

@ -7475,9 +7475,10 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
ErasureCodingPolicy[] policies, final boolean logRetryCache) ErasureCodingPolicy[] policies, final boolean logRetryCache)
throws IOException { throws IOException {
final String operationName = "addErasureCodingPolicies"; final String operationName = "addErasureCodingPolicies";
String addECPolicyName = ""; List<String> addECPolicyNames = new ArrayList<>(policies.length);
checkOperation(OperationCategory.WRITE); checkOperation(OperationCategory.WRITE);
List<AddErasureCodingPolicyResponse> responses = new ArrayList<>(); List<AddErasureCodingPolicyResponse> responses =
new ArrayList<>(policies.length);
boolean success = false; boolean success = false;
writeLock(); writeLock();
try { try {
@ -7488,7 +7489,7 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
ErasureCodingPolicy newPolicy = ErasureCodingPolicy newPolicy =
FSDirErasureCodingOp.addErasureCodingPolicy(this, policy, FSDirErasureCodingOp.addErasureCodingPolicy(this, policy,
logRetryCache); logRetryCache);
addECPolicyName = newPolicy.getName(); addECPolicyNames.add(newPolicy.getName());
responses.add(new AddErasureCodingPolicyResponse(newPolicy)); responses.add(new AddErasureCodingPolicyResponse(newPolicy));
} catch (HadoopIllegalArgumentException e) { } catch (HadoopIllegalArgumentException e) {
responses.add(new AddErasureCodingPolicyResponse(policy, e)); responses.add(new AddErasureCodingPolicyResponse(policy, e));
@ -7501,7 +7502,8 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
if (success) { if (success) {
getEditLog().logSync(); getEditLog().logSync();
} }
logAuditEvent(success, operationName, addECPolicyName, null, null); logAuditEvent(success, operationName, addECPolicyNames.toString(),
null, null);
} }
} }