Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HADOOP-16827. TestHarFileSystem.testInheritedMethodsImplemented broken. (#1817) 

This is a regression caused by HADOOP-16759.

The test TestHarFileSystem uses introspection to verify that HarFileSystem
Does not implement methods to which there is a suitable implementation in
the base FileSystem class. Because of the way it checks this, refactoring
(protected) FileSystem methods in an IDE do not automatically change
the probes in TestHarFileSystem.

The changes in HADOOP-16759 did exactly that, and somehow managed
to get through the build/test process without this being noticed.

This patch fixes that failure.

Caused by and fixed by Steve Loughran.

Change-Id: If60d9c97058242871c02ad1addd424478f84f446

Signed-off-by: Mingliang Liu <liuml07@apache.org>
This commit is contained in:
Steve Loughran 2020-01-24 18:50:16 +00:00 committed by Mingliang Liu
parent d10f77e3c9
commit 839e6076c1
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java
View File

@ -19,6 +19,7 @@
package org.apache.hadoop.fs;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.impl.OpenFileParameters;
import org.apache.hadoop.fs.permission.AclEntry;
import org.apache.hadoop.fs.permission.AclStatus;
import org.apache.hadoop.fs.permission.FsAction;
@ -246,15 +247,11 @@ public class TestHarFileSystem {
CompletableFuture<FSDataInputStream> openFileWithOptions(
PathHandle pathHandle,
Set<String> mandatoryKeys,
Configuration options,
int bufferSize) throws IOException;
OpenFileParameters parameters) throws IOException;
CompletableFuture<FSDataInputStream> openFileWithOptions(
Path path,
Set<String> mandatoryKeys,
Configuration options,
int bufferSize) throws IOException;
OpenFileParameters parameters) throws IOException;
}
@Test