From 85adc6677ba28bf106361be595e709941cb36496 Mon Sep 17 00:00:00 2001 From: Andrew Wang Date: Fri, 9 Dec 2016 12:05:42 -0800 Subject: [PATCH] HDFS-11217. Annotate NameNode and DataNode MXBean interfaces as Private/Stable. Contributed by Jagadesh Kiran N. (cherry picked from commit 5bd7dece920b20da95755cf7fbba9b3f39c7da69) --- .../hadoop/hdfs/server/datanode/DataNodeMXBean.java | 6 ++++-- .../hadoop/hdfs/server/namenode/NameNodeMXBean.java | 6 ++++-- .../hadoop/hdfs/server/namenode/NameNodeStatusMXBean.java | 8 +++++--- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java index d56d8e6c453..66d1c6d0f12 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java @@ -24,9 +24,11 @@ import java.util.Map; /** * - * This is the JMX management interface for data node information + * This is the JMX management interface for data node information. + * End users shouldn't be implementing these interfaces, and instead + * access this information through the JMX APIs. */ -@InterfaceAudience.Public +@InterfaceAudience.Private @InterfaceStability.Stable public interface DataNodeMXBean { diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java index 46bbeadbcd2..817eedd6892 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java @@ -24,9 +24,11 @@ import org.apache.hadoop.classification.InterfaceStability; import org.apache.hadoop.hdfs.protocol.RollingUpgradeInfo; /** - * This is the JMX management interface for namenode information + * This is the JMX management interface for namenode information. + * End users shouldn't be implementing these interfaces, and instead + * access this information through the JMX APIs. */ -@InterfaceAudience.Public +@InterfaceAudience.Private @InterfaceStability.Stable public interface NameNodeMXBean { diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeStatusMXBean.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeStatusMXBean.java index 4f0b0011c80..7b373723ed2 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeStatusMXBean.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeStatusMXBean.java @@ -21,10 +21,12 @@ import org.apache.hadoop.classification.InterfaceAudience; import org.apache.hadoop.classification.InterfaceStability; /** - * This is the JMX management interface for NameNode status information + * This is the JMX management interface for NameNode status information. + * End users shouldn't be implementing these interfaces, and instead + * access this information through the JMX APIs. * */ -@InterfaceAudience.Public -@InterfaceStability.Evolving +@InterfaceAudience.Private +@InterfaceStability.Stable public interface NameNodeStatusMXBean { /**