Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-6499. Use NativeIO#renameTo instead of File#renameTo in FileJournalManager. Contributed by Yongjun Zhang. 

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-2@1602543 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Aaron Myers 2014-06-14 02:17:10 +00:00
parent 018793faa7
commit 8b1abad185
2 changed files with 19 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -183,6 +183,9 @@ Release 2.5.0 - UNRELEASED
HDFS-6529. Trace logging for RemoteBlockReader2 to identify remote datanode HDFS-6529. Trace logging for RemoteBlockReader2 to identify remote datanode
and file being read. (Anubhav Dhoot via atm) and file being read. (Anubhav Dhoot via atm)
HDFS-6499. Use NativeIO#renameTo instead of File#renameTo in
FileJournalManager. (Yongjun Zhang via atm)
OPTIMIZATIONS OPTIMIZATIONS
HDFS-6214. Webhdfs has poor throughput for files >2GB (daryn) HDFS-6214. Webhdfs has poor throughput for files >2GB (daryn)

22
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileJournalManager.java
View File

@ -42,6 +42,7 @@ import org.apache.hadoop.hdfs.server.namenode.NNStorage.NameNodeFile;
import org.apache.hadoop.hdfs.server.namenode.NNStorageRetentionManager.StoragePurger; import org.apache.hadoop.hdfs.server.namenode.NNStorageRetentionManager.StoragePurger;
import org.apache.hadoop.hdfs.server.protocol.NamespaceInfo; import org.apache.hadoop.hdfs.server.protocol.NamespaceInfo;
import org.apache.hadoop.hdfs.server.protocol.RemoteEditLog; import org.apache.hadoop.hdfs.server.protocol.RemoteEditLog;
import org.apache.hadoop.io.nativeio.NativeIO;
import com.google.common.annotations.VisibleForTesting; import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Joiner; import com.google.common.base.Joiner;
@ -132,10 +133,14 @@ public class FileJournalManager implements JournalManager {
Preconditions.checkState(!dstFile.exists(), Preconditions.checkState(!dstFile.exists(),
"Can't finalize edits file " + inprogressFile + " since finalized file " + "Can't finalize edits file " + inprogressFile + " since finalized file " +
"already exists"); "already exists");
if (!inprogressFile.renameTo(dstFile)) {
try {
NativeIO.renameTo(inprogressFile, dstFile);
} catch (IOException e) {
errorReporter.reportErrorOnFile(dstFile); errorReporter.reportErrorOnFile(dstFile);
throw new IllegalStateException("Unable to finalize edits file " + inprogressFile); throw new IllegalStateException("Unable to finalize edits file " + inprogressFile, e);
} }
if (inprogressFile.equals(currentInProgress)) { if (inprogressFile.equals(currentInProgress)) {
currentInProgress = null; currentInProgress = null;
} }
@ -513,11 +518,16 @@ public class FileJournalManager implements JournalManager {
File src = file; File src = file;
File dst = new File(src.getParent(), src.getName() + newSuffix); File dst = new File(src.getParent(), src.getName() + newSuffix);
// renameTo fails on Windows if the destination file already exists. // renameTo fails on Windows if the destination file already exists.
if (!src.renameTo(dst)) { try {
if (!dst.delete() || !src.renameTo(dst)) { if (dst.exists()) {
throw new IOException( if (!dst.delete()) {
"Couldn't rename log " + src + " to " + dst); throw new IOException("Couldn't delete " + dst);
}
} }
NativeIO.renameTo(src, dst);
} catch (IOException e) {
throw new IOException(
"Couldn't rename log " + src + " to " + dst, e);
} }
file = dst; file = dst;
} }