Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-16078. Remove unused parameters for DatanodeManager.handleLifeline() (#3119). Contributed by tomscut. 

Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
This commit is contained in:
litao 2021-06-20 12:50:52 +08:00 committed by Ayush Saxena
parent e55d76e26c
commit 8d241482bd
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
View File

@ -1876,18 +1876,16 @@ public class DatanodeManager {
* *
* @param nodeReg registration info for DataNode sending the lifeline * @param nodeReg registration info for DataNode sending the lifeline
* @param reports storage reports from DataNode * @param reports storage reports from DataNode
* @param blockPoolId block pool ID
* @param cacheCapacity cache capacity at DataNode * @param cacheCapacity cache capacity at DataNode
* @param cacheUsed cache used at DataNode * @param cacheUsed cache used at DataNode
* @param xceiverCount estimated count of transfer threads running at DataNode * @param xceiverCount estimated count of transfer threads running at DataNode
* @param maxTransfers count of transfers running at DataNode
* @param failedVolumes count of failed volumes at DataNode * @param failedVolumes count of failed volumes at DataNode
* @param volumeFailureSummary info on failed volumes at DataNode * @param volumeFailureSummary info on failed volumes at DataNode
* @throws IOException if there is an error * @throws IOException if there is an error
*/ */
public void handleLifeline(DatanodeRegistration nodeReg, public void handleLifeline(DatanodeRegistration nodeReg,
StorageReport[] reports, String blockPoolId, long cacheCapacity, StorageReport[] reports, long cacheCapacity,
long cacheUsed, int xceiverCount, int maxTransfers, int failedVolumes, long cacheUsed, int xceiverCount, int failedVolumes,
VolumeFailureSummary volumeFailureSummary) throws IOException { VolumeFailureSummary volumeFailureSummary) throws IOException {
if (LOG.isDebugEnabled()) { if (LOG.isDebugEnabled()) {
LOG.debug("Received handleLifeline from nodeReg = " + nodeReg); LOG.debug("Received handleLifeline from nodeReg = " + nodeReg);

3
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
View File

@ -4334,9 +4334,8 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
long cacheCapacity, long cacheUsed, int xceiverCount, int xmitsInProgress, long cacheCapacity, long cacheUsed, int xceiverCount, int xmitsInProgress,
int failedVolumes, VolumeFailureSummary volumeFailureSummary) int failedVolumes, VolumeFailureSummary volumeFailureSummary)
throws IOException { throws IOException {
int maxTransfer = blockManager.getMaxReplicationStreams() - xmitsInProgress;
blockManager.getDatanodeManager().handleLifeline(nodeReg, reports, blockManager.getDatanodeManager().handleLifeline(nodeReg, reports,
getBlockPoolId(), cacheCapacity, cacheUsed, xceiverCount, maxTransfer, cacheCapacity, cacheUsed, xceiverCount,
failedVolumes, volumeFailureSummary); failedVolumes, volumeFailureSummary);
} }