Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-16391. Avoid evaluation of LOG.debug statement in NameNodeHeartbeatService (#3820)

This commit is contained in:
wangzhaohui 2021-12-21 19:28:57 +08:00 committed by GitHub
parent 9420cb6f8a
commit 8d251bd629
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java
View File

@ -267,12 +267,16 @@ public class NamenodeHeartbeatService extends PeriodicService {
LOG.error("Namenode is not operational: {}", getNamenodeDesc()); LOG.error("Namenode is not operational: {}", getNamenodeDesc());
} else if (report.haStateValid()) { } else if (report.haStateValid()) {
// block and HA status available // block and HA status available
LOG.debug("Received service state: {} from HA namenode: {}", if (LOG.isDebugEnabled()) {
report.getState(), getNamenodeDesc()); LOG.debug("Received service state: {} from HA namenode: {}",
report.getState(), getNamenodeDesc());
}
} else if (localTarget == null) { } else if (localTarget == null) {
// block info available, HA status not expected // block info available, HA status not expected
LOG.debug( if (LOG.isDebugEnabled()) {
"Reporting non-HA namenode as operational: " + getNamenodeDesc()); LOG.debug(
"Reporting non-HA namenode as operational: {}", getNamenodeDesc());
}
} else { } else {
// block info available, HA status should be available, but was not // block info available, HA status should be available, but was not
// fetched do nothing and let the current state stand // fetched do nothing and let the current state stand