diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java index fc7e88ba123..cec9915e0d1 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java @@ -1325,6 +1325,13 @@ public void transition(RMNodeImpl rmNode, RMNodeEvent event) { .handle( new NodeResourceUpdateSchedulerEvent(rmNode, ResourceOption .newInstance(rmNode.totalCapability, 0))); + + // Notify NodesListManager to notify all RMApp that this node has been + // recommissioned so that each Application Master can take any required + // actions. + rmNode.context.getDispatcher().getEventHandler().handle( + new NodesListManagerEvent( + NodesListManagerEventType.NODE_USABLE, rmNode)); } } diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/applicationsmanager/TestAMRMRPCNodeUpdates.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/applicationsmanager/TestAMRMRPCNodeUpdates.java index a14130f9fd0..c4291b6040b 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/applicationsmanager/TestAMRMRPCNodeUpdates.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/applicationsmanager/TestAMRMRPCNodeUpdates.java @@ -22,6 +22,7 @@ import java.util.List; import org.apache.hadoop.yarn.server.resourcemanager.MockRMAppSubmitter; +import org.apache.hadoop.yarn.server.resourcemanager.rmnode.RMNodeEventType; import org.junit.Assert; import org.apache.hadoop.conf.Configuration; @@ -91,6 +92,12 @@ private void syncNodeGracefulDecommission( rm.drainEvents(); } + private void syncNodeRecommissioning(MockNM nm) throws Exception { + rm.sendNodeEvent(nm, RMNodeEventType.RECOMMISSION); + rm.waitForState(nm.getNodeId(), NodeState.RUNNING); + rm.drainEvents(); + } + private AllocateResponse allocate(final ApplicationAttemptId attemptId, final AllocateRequest req) throws Exception { UserGroupInformation ugi = @@ -140,6 +147,53 @@ public void testAMRMDecommissioningNodes() throws Exception { NodeUpdateType.NODE_DECOMMISSIONING, nr.getNodeUpdateType()); } + @Test + public void testAMRMRecommissioningNodes() throws Exception { + MockNM nm1 = rm.registerNode("127.0.0.1:1234", 10000); + MockNM nm2 = rm.registerNode("127.0.0.2:1234", 10000); + rm.drainEvents(); + + RMApp app1 = MockRMAppSubmitter.submitWithMemory(2000, rm); + + // Trigger the scheduling so the AM gets 'launched' on nm1 + nm1.nodeHeartbeat(true); + + RMAppAttempt attempt1 = app1.getCurrentAppAttempt(); + MockAM am1 = rm.sendAMLaunched(attempt1.getAppAttemptId()); + + // register AM returns no unusable node + am1.registerAppAttempt(); + + // DECOMMISSION nm2 + Integer decommissioningTimeout = 600; + syncNodeGracefulDecommission(nm2, decommissioningTimeout); + + AllocateRequest allocateRequest1 = + AllocateRequest.newInstance(0, 0F, null, null, null); + AllocateResponse response1 = + allocate(attempt1.getAppAttemptId(), allocateRequest1); + List updatedNodes = response1.getUpdatedNodes(); + Assert.assertEquals(1, updatedNodes.size()); + NodeReport nr = updatedNodes.iterator().next(); + Assert.assertEquals( + decommissioningTimeout, nr.getDecommissioningTimeout()); + Assert.assertEquals( + NodeUpdateType.NODE_DECOMMISSIONING, nr.getNodeUpdateType()); + + // Wait for nm2 to RECOMMISSION + syncNodeRecommissioning(nm2); + + AllocateRequest allocateRequest2 = AllocateRequest + .newInstance(response1.getResponseId(), 0F, null, null, null); + AllocateResponse response2 = + allocate(attempt1.getAppAttemptId(), allocateRequest2); + List updatedNodes2 = response2.getUpdatedNodes(); + Assert.assertEquals(1, updatedNodes2.size()); + NodeReport nr2 = updatedNodes2.iterator().next(); + Assert.assertEquals( + NodeUpdateType.NODE_USABLE, nr2.getNodeUpdateType()); + } + @Test public void testAMRMUnusableNodes() throws Exception {