From 98ba68b05dbfc1c9c23e4c921ad062c0b51cd6b6 Mon Sep 17 00:00:00 2001 From: Arpit Agarwal Date: Mon, 28 Aug 2017 15:49:59 -0700 Subject: [PATCH] HDFS-12293. DataNode should log file name on disk error. Contributed by Ajay Kumar. --- .../org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java | 3 ++- .../java/org/apache/hadoop/hdfs/server/datanode/DataNode.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java index 03cf3a0f632..c8a33caf706 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java @@ -281,7 +281,8 @@ class BlockReceiver implements Closeable { // check if there is a disk error IOException cause = DatanodeUtil.getCauseIfDiskError(ioe); - DataNode.LOG.warn("IOException in BlockReceiver constructor" + DataNode.LOG + .warn("IOException in BlockReceiver constructor :" + ioe.getMessage() + (cause == null ? "" : ". Cause is "), cause); if (cause != null) { ioe = cause; diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java index c1a96cb87c0..73d77af34aa 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java @@ -2490,7 +2490,8 @@ public void run() { // disk check moved to FileIoProvider IOException cause = DatanodeUtil.getCauseIfDiskError(ie); if (cause != null) { // possible disk error - LOG.warn("IOException in DataTransfer#run(). Cause is ", cause); + LOG.warn("IOException in DataTransfer#run() "+ ie.getMessage() +". " + + "Cause is ", cause); } } finally { xmitsInProgress.getAndDecrement();