MAPREDUCE-6221. Stringifier is left unclosed in Chain#getChainElementConf(). Contributed by Ted Yu.

This commit is contained in:
Tsuyoshi Ozawa 2015-02-13 02:27:54 +09:00
parent 8d7215d40f
commit 9b0ba59b82
2 changed files with 5 additions and 3 deletions

View File

@ -356,6 +356,9 @@ Release 2.7.0 - UNRELEASED
MAPREDUCE-6233. org.apache.hadoop.mapreduce.TestLargeSort.testLargeSort MAPREDUCE-6233. org.apache.hadoop.mapreduce.TestLargeSort.testLargeSort
failed in trunk (zxu via rkanter) failed in trunk (zxu via rkanter)
MAPREDUCE-6221. Stringifier is left unclosed in Chain#getChainElementConf().
(Ted Yu via ozawa)
Release 2.6.1 - UNRELEASED Release 2.6.1 - UNRELEASED
INCOMPATIBLE CHANGES INCOMPATIBLE CHANGES

View File

@ -575,9 +575,8 @@ public class Chain {
protected static Configuration getChainElementConf(Configuration jobConf, protected static Configuration getChainElementConf(Configuration jobConf,
String confKey) { String confKey) {
Configuration conf = null; Configuration conf = null;
try { try (Stringifier<Configuration> stringifier =
Stringifier<Configuration> stringifier = new DefaultStringifier<Configuration>(jobConf, Configuration.class);) {
new DefaultStringifier<Configuration>(jobConf, Configuration.class);
String confString = jobConf.get(confKey, null); String confString = jobConf.get(confKey, null);
if (confString != null) { if (confString != null) {
conf = stringifier.fromString(jobConf.get(confKey, null)); conf = stringifier.fromString(jobConf.get(confKey, null));