Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-9797. Log Standby exceptions thrown by RequestHedgingProxyProvider at DEBUG Level (Inigo Goiri via asuresh)

This commit is contained in:
Arun Suresh 2016-02-12 11:18:10 -08:00
parent 972782d956
commit 9fdfb546fb
2 changed files with 42 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -1919,6 +1919,9 @@ Release 2.8.0 - UNRELEASED
HDFS-9644. Update encryption documentation to reflect nested EZs. (zhz) HDFS-9644. Update encryption documentation to reflect nested EZs. (zhz)
HDFS-9797. Log Standby exceptions thrown by RequestHedgingProxyProvider
at DEBUG Level (Inigo Goiri via asuresh)
OPTIMIZATIONS OPTIMIZATIONS
HDFS-8026. Trace FSOutputSummer#writeChecksumChunks rather than HDFS-8026. Trace FSOutputSummer#writeChecksumChunks rather than

41
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/RequestHedgingProxyProvider.java
View File

@ -17,6 +17,7 @@
*/ */
package org.apache.hadoop.hdfs.server.namenode.ha; package org.apache.hadoop.hdfs.server.namenode.ha;
import java.io.IOException;
import java.lang.reflect.InvocationHandler; import java.lang.reflect.InvocationHandler;
import java.lang.reflect.Method; import java.lang.reflect.Method;
import java.lang.reflect.Proxy; import java.lang.reflect.Proxy;
@ -33,6 +34,8 @@ import java.util.concurrent.Future;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.ipc.RemoteException;
import org.apache.hadoop.ipc.StandbyException;
import com.google.common.annotations.VisibleForTesting; import com.google.common.annotations.VisibleForTesting;
import org.apache.hadoop.io.retry.MultiException; import org.apache.hadoop.io.retry.MultiException;
@ -118,8 +121,7 @@ public class RequestHedgingProxyProvider<T> extends
return retVal; return retVal;
} catch (Exception ex) { } catch (Exception ex) {
ProxyInfo<T> tProxyInfo = proxyMap.get(callResultFuture); ProxyInfo<T> tProxyInfo = proxyMap.get(callResultFuture);
LOG.warn("Invocation returned exception on " logProxyException(ex, tProxyInfo.proxyInfo);
+ "[" + tProxyInfo.proxyInfo + "]");
badResults.put(tProxyInfo.proxyInfo, ex); badResults.put(tProxyInfo.proxyInfo, ex);
numAttempts--; numAttempts--;
} }
@ -183,4 +185,39 @@ public class RequestHedgingProxyProvider<T> extends
successfulProxy = null; successfulProxy = null;
} }
/**
* Check the exception returned by the proxy log a warning message if it's
* not a StandbyException (expected exception).
* @param ex Exception to evaluate.
* @param proxyInfo Information of the proxy reporting the exception.
*/
private void logProxyException(Exception ex, String proxyInfo) {
if (isStandbyException(ex)) {
if (LOG.isDebugEnabled()) {
LOG.debug("Invocation returned standby exception on [" +
proxyInfo + "]");
}
} else {
LOG.warn("Invocation returned exception on [" + proxyInfo + "]");
}
}
/**
* Check if the returned exception is caused by an standby namenode.
* @param ex Exception to check.
* @return If the exception is caused by an standby namenode.
*/
private boolean isStandbyException(Exception ex) {
Throwable cause = ex.getCause();
if (cause != null) {
Throwable cause2 = cause.getCause();
if (cause2 instanceof RemoteException) {
RemoteException remoteException = (RemoteException)cause2;
IOException unwrapRemoteException =
remoteException.unwrapRemoteException();
return unwrapRemoteException instanceof StandbyException;
}
}
return false;
}
} }