diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java index 52e6a015826..1d7f2f53285 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java @@ -99,6 +99,17 @@ extends AbstractDelegationTokenIdentifier> */ protected Object noInterruptsLock = new Object(); + /** + * Create a secret manager + * @param delegationKeyUpdateInterval the number of milliseconds for rolling + * new secret keys. + * @param delegationTokenMaxLifetime the maximum lifetime of the delegation + * tokens in milliseconds + * @param delegationTokenRenewInterval how often the tokens must be renewed + * in milliseconds + * @param delegationTokenRemoverScanInterval how often the tokens are scanned + * for expired tokens in milliseconds + */ public AbstractDelegationTokenSecretManager(long delegationKeyUpdateInterval, long delegationTokenMaxLifetime, long delegationTokenRenewInterval, long delegationTokenRemoverScanInterval) { diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenSecretManager.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenSecretManager.java index 8af7ebaa0bf..b7f89a896da 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenSecretManager.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenSecretManager.java @@ -79,13 +79,14 @@ public class DelegationTokenSecretManager /** * Create a secret manager - * @param delegationKeyUpdateInterval the number of seconds for rolling new - * secret keys. + * @param delegationKeyUpdateInterval the number of milliseconds for rolling + * new secret keys. * @param delegationTokenMaxLifetime the maximum lifetime of the delegation - * tokens + * tokens in milliseconds * @param delegationTokenRenewInterval how often the tokens must be renewed + * in milliseconds * @param delegationTokenRemoverScanInterval how often the tokens are scanned - * for expired tokens + * for expired tokens in milliseconds * @param storeTokenTrackingId whether to store the token's tracking id */ public DelegationTokenSecretManager(long delegationKeyUpdateInterval, diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/token/delegation/DelegationTokenSecretManager.java b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/token/delegation/DelegationTokenSecretManager.java index b42e0c9f8c1..2a109b63b23 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/token/delegation/DelegationTokenSecretManager.java +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/token/delegation/DelegationTokenSecretManager.java @@ -34,13 +34,14 @@ public class DelegationTokenSecretManager /** * Create a secret manager - * @param delegationKeyUpdateInterval the number of seconds for rolling new - * secret keys. + * @param delegationKeyUpdateInterval the number of milliseconds for rolling + * new secret keys. * @param delegationTokenMaxLifetime the maximum lifetime of the delegation - * tokens + * tokens in milliseconds * @param delegationTokenRenewInterval how often the tokens must be renewed + * in milliseconds * @param delegationTokenRemoverScanInterval how often the tokens are scanned - * for expired tokens + * for expired tokens in milliseconds */ public DelegationTokenSecretManager(long delegationKeyUpdateInterval, long delegationTokenMaxLifetime, diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JHSDelegationTokenSecretManager.java b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JHSDelegationTokenSecretManager.java index 7fac44df8cf..98d13a46023 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JHSDelegationTokenSecretManager.java +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JHSDelegationTokenSecretManager.java @@ -47,13 +47,14 @@ public class JHSDelegationTokenSecretManager /** * Create a secret manager - * @param delegationKeyUpdateInterval the number of seconds for rolling new - * secret keys. + * @param delegationKeyUpdateInterval the number of milliseconds for rolling + * new secret keys. * @param delegationTokenMaxLifetime the maximum lifetime of the delegation - * tokens + * tokens in milliseconds * @param delegationTokenRenewInterval how often the tokens must be renewed + * in milliseconds * @param delegationTokenRemoverScanInterval how often the tokens are scanned - * for expired tokens + * for expired tokens in milliseconds * @param store history server state store for persisting state */ public JHSDelegationTokenSecretManager(long delegationKeyUpdateInterval, diff --git a/hadoop-yarn-project/CHANGES.txt b/hadoop-yarn-project/CHANGES.txt index 97de524ec42..e9ecc9eb74e 100644 --- a/hadoop-yarn-project/CHANGES.txt +++ b/hadoop-yarn-project/CHANGES.txt @@ -179,6 +179,9 @@ Release 2.8.0 - UNRELEASED YARN-3395. FairScheduler: Trim whitespaces when using username for queuename. (Zhihai Xu via kasha) + YARN-3587. Fix the javadoc of DelegationTokenSecretManager in yarn, etc. + projects. (Gabor Liptak via junping_du) + OPTIMIZATIONS YARN-3339. TestDockerContainerExecutor should pull a single image and not diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineDelegationTokenSecretManagerService.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineDelegationTokenSecretManagerService.java index c940eea7037..60a0348b045 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineDelegationTokenSecretManagerService.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineDelegationTokenSecretManagerService.java @@ -125,11 +125,15 @@ public class TimelineDelegationTokenSecretManagerService extends /** * Create a timeline secret manager - * - * @param delegationKeyUpdateInterval the number of seconds for rolling new secret keys. - * @param delegationTokenMaxLifetime the maximum lifetime of the delegation tokens + * @param delegationKeyUpdateInterval the number of milliseconds for rolling + * new secret keys. + * @param delegationTokenMaxLifetime the maximum lifetime of the delegation + * tokens in milliseconds * @param delegationTokenRenewInterval how often the tokens must be renewed - * @param delegationTokenRemoverScanInterval how often the tokens are scanned for expired tokens + * in milliseconds + * @param delegationTokenRemoverScanInterval how often the tokens are + * scanned for expired tokens in milliseconds + * @param stateStore timeline service state store */ public TimelineDelegationTokenSecretManager( long delegationKeyUpdateInterval, diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/RMDelegationTokenSecretManager.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/RMDelegationTokenSecretManager.java index 83defc54247..631ca9d2e5a 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/RMDelegationTokenSecretManager.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/RMDelegationTokenSecretManager.java @@ -56,13 +56,15 @@ public class RMDelegationTokenSecretManager extends /** * Create a secret manager - * @param delegationKeyUpdateInterval the number of seconds for rolling new - * secret keys. + * @param delegationKeyUpdateInterval the number of milliseconds for rolling + * new secret keys. * @param delegationTokenMaxLifetime the maximum lifetime of the delegation - * tokens + * tokens in milliseconds * @param delegationTokenRenewInterval how often the tokens must be renewed + * in milliseconds * @param delegationTokenRemoverScanInterval how often the tokens are scanned - * for expired tokens + * for expired tokens in milliseconds + * @param rmContext current context of the ResourceManager */ public RMDelegationTokenSecretManager(long delegationKeyUpdateInterval, long delegationTokenMaxLifetime,