MAPREDUCE-3296. Fixed the remaining nine FindBugs warnings. (vinodkv)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1190187 13f79535-47bb-0310-9956-ffa450edef68

hadoop-mapreduce-project/CHANGES.txt

@@ -1841,9 +1841,11 @@ Release 0.23.0 - Unreleased
     MAPREDUCE-3185. RM Web UI does not sort the columns in some cases.
     (Jonathan Eagles via mahadev)
 
-   MAPREDUCE-3292. In secure mode job submission fails with Provider 
+    MAPREDUCE-3292. In secure mode job submission fails with Provider 
-   org.apache.hadoop.mapreduce.security.token.JobTokenIndentifier$Renewer 
+    org.apache.hadoop.mapreduce.security.token.JobTokenIndentifier$Renewer 
-   not found. (mahadev)
+    not found. (mahadev)
+
+    MAPREDUCE-3296. Fixed the remaining nine FindBugs warnings. (vinodkv)
 
 Release 0.22.0 - Unreleased
 

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java

@@ -44,8 +44,8 @@ import org.mortbay.log.Log;
  * </p>
  */
 public class JobEndNotifier implements Configurable {
-  final String JOB_ID = "$jobId";
+  private static final String JOB_ID = "$jobId";
-  final String JOB_STATUS = "$jobStatus";
+  private static final String JOB_STATUS = "$jobStatus";
 
   private Configuration conf;
   protected String userUrl;

hadoop-mapreduce-project/hadoop-yarn/dev-support/findbugs-exclude.xml

@@ -171,6 +171,10 @@
     <Class name="org.apache.hadoop.yarn.webapp.WebApps$Builder" />
     <Bug pattern="DM_EXIT" />
   </Match>
+  <Match>
+    <Class name="org.apache.hadoop.yarn.server.resourcemanager.security.DelegationTokenRenewer$DelegationTokenCancelThread" />
+    <Bug pattern="DM_EXIT" />
+  </Match>
   <!-- AsyncDispatcher will kill the process if there is an error dispatching -->
   <Match>
     <Class name="org.apache.hadoop.yarn.event.AsyncDispatcher" />
@@ -185,6 +189,17 @@
     <Bug pattern="DE_MIGHT_IGNORE" />
   </Match>
 
+  <!-- Ignore EI_EXPOSE_REP in PolicyProviders -->
+  <Match>
+    <Class name="org.apache.hadoop.yarn.server.resourcemanager.security.authorize.RMPolicyProvider" />
+    <Bug pattern="EI_EXPOSE_REP" />
+  </Match>
+  <Match>
+    <Class name="org.apache.hadoop.yarn.server.nodemanager.security.authorize.NMPolicyProvider" />
+    <Bug pattern="EI_EXPOSE_REP" />
+  </Match>
+
+
   <!-- Ignore EI_EXPOSE_REP2 in Log services -->
   <Match>
     <Class name="org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.AggregatedLogFormat$LogValue" />

hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java

@@ -20,6 +20,7 @@ package org.apache.hadoop.yarn.webapp;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 
+import java.io.IOException;
 import java.net.ConnectException;
 import java.net.URL;
 import java.util.HashMap;
@@ -191,7 +192,9 @@ public class WebApps {
         webapp.setHttpServer(server);
         server.start();
         LOG.info("Web app /"+ name +" started at "+ server.getPort());
-      } catch (Exception e) {
+      } catch (ClassNotFoundException e) {
+        throw new WebAppException("Error starting http server", e);
+      } catch (IOException e) {
         throw new WebAppException("Error starting http server", e);
       }
       Injector injector = Guice.createInjector(webapp, new AbstractModule() {

hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/ProxyUriUtils.java

@@ -92,7 +92,7 @@ public class ProxyUriUtils {
     newp.append(getPath(id, path));
     boolean first = appendQuery(newp, query, true);
     if(approved) {
-      first = appendQuery(newp, PROXY_APPROVAL_PARAM+"=true", first);
+      appendQuery(newp, PROXY_APPROVAL_PARAM+"=true", first);
     }
     return newp.toString();
   }

hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/amfilter/AmIpFilter.java

@@ -59,8 +59,8 @@ public class AmIpFilter implements Filter {
   
   private Set<String> getProxyAddresses() throws ServletException {
     long now = System.currentTimeMillis();
-    if(proxyAddresses == null || (lastUpdate + updateInterval) >= now) {
+    synchronized(this) {
-      synchronized(this) {
+      if(proxyAddresses == null || (lastUpdate + updateInterval) >= now) {
         try {
           proxyAddresses = new HashSet<String>();
           for(InetAddress add : InetAddress.getAllByName(proxyHost)) {
@@ -71,8 +71,8 @@ public class AmIpFilter implements Filter {
           throw new ServletException("Could not locate "+proxyHost, e);
         }
       }
+      return proxyAddresses;
     }
-    return proxyAddresses;
   }
 
   @Override