From a4835db95a2cca255bf0e40fa5d016526ef03857 Mon Sep 17 00:00:00 2001 From: Szilard Nemeth Date: Fri, 5 Jun 2020 10:11:40 +0200 Subject: [PATCH] YARN-10296. Make ContainerPBImpl#getId/setId synchronized. Contributed by Benjamin Teke --- .../hadoop/yarn/api/records/impl/pb/ContainerPBImpl.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ContainerPBImpl.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ContainerPBImpl.java index b3dad0a0165..53d52d3c94a 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ContainerPBImpl.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ContainerPBImpl.java @@ -68,7 +68,7 @@ public class ContainerPBImpl extends Container { viaProto = true; } - public ContainerProto getProto() { + synchronized public ContainerProto getProto() { mergeLocalToProto(); proto = viaProto ? proto : builder.build(); @@ -142,7 +142,7 @@ public class ContainerPBImpl extends Container { } @Override - public ContainerId getId() { + synchronized public ContainerId getId() { ContainerProtoOrBuilder p = viaProto ? proto : builder; if (this.containerId != null) { return this.containerId; @@ -176,7 +176,7 @@ public class ContainerPBImpl extends Container { } @Override - public void setId(ContainerId id) { + synchronized public void setId(ContainerId id) { maybeInitBuilder(); if (id == null) builder.clearId();