From a4b1793df049c2073c535e53f31a022321b8e9f0 Mon Sep 17 00:00:00 2001 From: Aaron Myers Date: Mon, 4 Jun 2012 23:06:19 +0000 Subject: [PATCH] HDFS-3266. DFSTestUtil#waitCorruptReplicas doesn't sleep between checks. Contributed by Madhukara Phatak. git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1346192 13f79535-47bb-0310-9956-ffa450edef68 --- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 +++ .../src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index fc9f484bd3f..cf0fb480f46 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -304,6 +304,9 @@ Release 2.0.1-alpha - UNRELEASED HDFS-3501. Checkpointing with security enabled will stop working after ticket lifetime expires. (atm via eli) + HDFS-3266. DFSTestUtil#waitCorruptReplicas doesn't sleep between checks. + (Madhukara Phatak via atm) + Release 2.0.0-alpha - 05-23-2012 INCOMPATIBLE CHANGES diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java index 7e793a59bd9..1ed534c0065 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java @@ -323,7 +323,7 @@ public class DFSTestUtil { */ public static void waitCorruptReplicas(FileSystem fs, FSNamesystem ns, Path file, ExtendedBlock b, int corruptRepls) - throws IOException, TimeoutException { + throws IOException, TimeoutException, InterruptedException { int count = 0; final int ATTEMPTS = 50; int repls = ns.getBlockManager().numCorruptReplicas(b.getLocalBlock()); @@ -337,6 +337,7 @@ public class DFSTestUtil { System.out.println("Waiting for "+corruptRepls+" corrupt replicas"); repls = ns.getBlockManager().numCorruptReplicas(b.getLocalBlock()); count++; + Thread.sleep(1000); } if (count == ATTEMPTS) { throw new TimeoutException("Timed out waiting for corrupt replicas."