From a628a6f126473a99f9370ba642994ce2909a2d9e Mon Sep 17 00:00:00 2001 From: Zhihai Xu Date: Fri, 31 Jul 2015 21:32:45 -0700 Subject: [PATCH] HADOOP-12268. AbstractContractAppendTest#testRenameFileBeingAppended misses rename operation. Contributed by Zhihai Xu --- hadoop-common-project/hadoop-common/CHANGES.txt | 3 +++ .../apache/hadoop/fs/contract/AbstractContractAppendTest.java | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index 1412fb83e99..09df2f14ef0 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -1041,6 +1041,9 @@ Release 2.8.0 - UNRELEASED each platform, not hardcoded to their Linux values (Martin Walsh via Colin P. McCabe) + HADOOP-12268. AbstractContractAppendTest#testRenameFileBeingAppended + misses rename operation. (Zhihai Xu) + Release 2.7.2 - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractAppendTest.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractAppendTest.java index 96287057a05..d3e674174d1 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractAppendTest.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractAppendTest.java @@ -24,13 +24,12 @@ import org.junit.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import static org.apache.hadoop.fs.contract.ContractTestUtils.cleanup; import static org.apache.hadoop.fs.contract.ContractTestUtils.createFile; import static org.apache.hadoop.fs.contract.ContractTestUtils.dataset; import static org.apache.hadoop.fs.contract.ContractTestUtils.touch; /** - * Test concat -if supported + * Test append -if supported */ public abstract class AbstractContractAppendTest extends AbstractFSContractTestBase { private static final Logger LOG = @@ -112,6 +111,7 @@ public abstract class AbstractContractAppendTest extends AbstractFSContractTestB FSDataOutputStream outputStream = getFileSystem().append(target); outputStream.write(dataset); Path renamed = new Path(testPath, "renamed"); + rename(target, renamed); outputStream.close(); String listing = ls(testPath);