From a7232f5e1d20faf210f3718c551cbae4edb5933c Mon Sep 17 00:00:00 2001 From: cnauroth Date: Fri, 5 Feb 2016 15:07:43 -0800 Subject: [PATCH] HDFS-9761. Rebalancer sleeps too long between iterations. Contributed by Mingliang Liu. (cherry picked from commit c6497949e866594050153b953a85c0a1db59d2f8) --- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 +++ .../org/apache/hadoop/hdfs/server/balancer/Balancer.java | 7 +++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index e7563f24cb6..21e90d8d040 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -1797,6 +1797,9 @@ Release 2.8.0 - UNRELEASED HDFS-9601. NNThroughputBenchmark.BlockReportStats should handle NotReplicatedYetException on adding block (iwasakims) + HDFS-9761. Rebalancer sleeps too long between iterations + (Mingliang Liu via cnauroth) + Release 2.7.3 - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java index dcae9226400..8be62ac992e 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java @@ -673,14 +673,13 @@ public class Balancer { // must be an error statue, return. return r.exitStatus.getExitCode(); } - - if (!done) { - Thread.sleep(sleeptime); - } } else { LOG.info("Skipping blockpool " + nnc.getBlockpoolID()); } } + if (!done) { + Thread.sleep(sleeptime); + } } } finally { for(NameNodeConnector nnc : connectors) {