Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-11342. Fix FileInputStream leak in loadLastPartialChunkChecksum. Contributed by Chen Liang.

This commit is contained in:
Arpit Agarwal 2017-01-16 13:45:22 -08:00
parent 2f8e9b7e4b
commit a853b4e1b5
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java
View File

@ -19,6 +19,7 @@ package org.apache.hadoop.hdfs.server.datanode.fsdataset.impl;
import java.io.BufferedWriter; import java.io.BufferedWriter;
import java.io.File; import java.io.File;
import java.io.FileInputStream;
import java.io.FilenameFilter; import java.io.FilenameFilter;
import java.io.IOException; import java.io.IOException;
import java.io.OutputStreamWriter; import java.io.OutputStreamWriter;
@ -1122,9 +1123,11 @@ public class FsVolumeImpl implements FsVolumeSpi {
public byte[] loadLastPartialChunkChecksum( public byte[] loadLastPartialChunkChecksum(
File blockFile, File metaFile) throws IOException { File blockFile, File metaFile) throws IOException {
// readHeader closes the temporary FileInputStream. // readHeader closes the temporary FileInputStream.
DataChecksum dcs = BlockMetadataHeader DataChecksum dcs;
.readHeader(fileIoProvider.getFileInputStream(this, metaFile)) try (FileInputStream fis = fileIoProvider.getFileInputStream(
.getChecksum(); this, metaFile)) {
dcs = BlockMetadataHeader.readHeader(fis).getChecksum();
}
final int checksumSize = dcs.getChecksumSize(); final int checksumSize = dcs.getChecksumSize();
final long onDiskLen = blockFile.length(); final long onDiskLen = blockFile.length();
final int bytesPerChecksum = dcs.getBytesPerChecksum(); final int bytesPerChecksum = dcs.getBytesPerChecksum();