From aa22450442ebe39916a6fd460fe97e347945526d Mon Sep 17 00:00:00 2001 From: Andrew Wang Date: Wed, 29 Apr 2015 17:37:56 -0700 Subject: [PATCH] HDFS-8214. Secondary NN Web UI shows wrong date for Last Checkpoint. Contributed by Charles Lamb. --- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 2 ++ .../server/namenode/SecondaryNameNode.java | 35 +++++++++++++------ .../namenode/SecondaryNameNodeInfoMXBean.java | 6 ++++ .../src/main/webapps/secondary/status.html | 2 +- .../src/main/webapps/static/dfs-dust.js | 3 ++ 5 files changed, 36 insertions(+), 12 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index a3f219bac4a..fbeb45dee16 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -582,6 +582,8 @@ Release 2.8.0 - UNRELEASED HDFS-8232. Missing datanode counters when using Metrics2 sink interface. (Anu Engineer via cnauroth) + HDFS-8214. Secondary NN Web UI shows wrong date for Last Checkpoint. (clamb via wang) + Release 2.7.1 - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java index ec7e0c94703..b499e74dc22 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java @@ -108,6 +108,7 @@ public class SecondaryNameNode implements Runnable, private final long starttime = Time.now(); private volatile long lastCheckpointTime = 0; + private volatile long lastCheckpointWallclockTime = 0; private URL fsName; private CheckpointStorage checkpointImage; @@ -134,8 +135,9 @@ public class SecondaryNameNode implements Runnable, + "\nName Node Address : " + nameNodeAddr + "\nStart Time : " + new Date(starttime) + "\nLast Checkpoint : " + (lastCheckpointTime == 0? "--": - ((Time.monotonicNow() - lastCheckpointTime) / 1000)) - + " seconds ago" + new Date(lastCheckpointWallclockTime)) + + " (" + ((Time.monotonicNow() - lastCheckpointTime) / 1000) + + " seconds ago)" + "\nCheckpoint Period : " + checkpointConf.getPeriod() + " seconds" + "\nCheckpoint Transactions: " + checkpointConf.getTxnCount() + "\nCheckpoint Dirs : " + checkpointDirs @@ -388,12 +390,14 @@ public class SecondaryNameNode implements Runnable, if(UserGroupInformation.isSecurityEnabled()) UserGroupInformation.getCurrentUser().checkTGTAndReloginFromKeytab(); - final long now = Time.monotonicNow(); + final long monotonicNow = Time.monotonicNow(); + final long now = Time.now(); if (shouldCheckpointBasedOnCount() || - now >= lastCheckpointTime + 1000 * checkpointConf.getPeriod()) { + monotonicNow >= lastCheckpointTime + 1000 * checkpointConf.getPeriod()) { doCheckpoint(); - lastCheckpointTime = now; + lastCheckpointTime = monotonicNow; + lastCheckpointWallclockTime = now; } } catch (IOException e) { LOG.error("Exception in doCheckpoint", e); @@ -695,22 +699,31 @@ public class SecondaryNameNode implements Runnable, checkpointThread.start(); } - @Override // SecondaryNameNodeInfoMXXBean + @Override // SecondaryNameNodeInfoMXBean public String getHostAndPort() { return NetUtils.getHostPortString(nameNodeAddr); } - @Override // SecondaryNameNodeInfoMXXBean + @Override // SecondaryNameNodeInfoMXBean public long getStartTime() { return starttime; } - @Override // SecondaryNameNodeInfoMXXBean + @Override // SecondaryNameNodeInfoMXBean public long getLastCheckpointTime() { - return lastCheckpointTime; + return lastCheckpointWallclockTime; } - @Override // SecondaryNameNodeInfoMXXBean + @Override // SecondaryNameNodeInfoMXBean + public long getLastCheckpointDeltaMs() { + if (lastCheckpointTime == 0) { + return -1; + } else { + return (Time.monotonicNow() - lastCheckpointTime); + } + } + + @Override // SecondaryNameNodeInfoMXBean public String[] getCheckpointDirectories() { ArrayList r = Lists.newArrayListWithCapacity(checkpointDirs.size()); for (URI d : checkpointDirs) { @@ -719,7 +732,7 @@ public class SecondaryNameNode implements Runnable, return r.toArray(new String[r.size()]); } - @Override // SecondaryNameNodeInfoMXXBean + @Override // SecondaryNameNodeInfoMXBean public String[] getCheckpointEditlogDirectories() { ArrayList r = Lists.newArrayListWithCapacity(checkpointEditsDirs.size()); for (URI d : checkpointEditsDirs) { diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNodeInfoMXBean.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNodeInfoMXBean.java index 01f6fac99c7..785c5ee3103 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNodeInfoMXBean.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNodeInfoMXBean.java @@ -41,6 +41,12 @@ public interface SecondaryNameNodeInfoMXBean extends VersionInfoMXBean { */ public long getLastCheckpointTime(); + /** + * @return the number of msec since the last checkpoint, or -1 if no + * checkpoint has been done yet. + */ + public long getLastCheckpointDeltaMs(); + /** * @return the directories that store the checkpoint images */ diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html b/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html index 7893a179bdc..2ef58ad9e4e 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary/status.html @@ -65,7 +65,7 @@ Compiled{CompileInfo} NameNode Address{HostAndPort} Started{StartTime|date_tostring} - Last Checkpoint{@if cond="{LastCheckpointTime} === 0"}Never{:else}{LastCheckpointTime|date_tostring}{/if} + Last Checkpoint{@if cond="{LastCheckpointTime} === 0"}Never{:else}{LastCheckpointTime|date_tostring} ({LastCheckpointDeltaMs|fmt_time} ago){/if} Checkpoint Period{CheckpointPeriod} seconds Checkpoint Transactions{TxnCount} diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js b/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js index 3c8efd97a04..f483d23d0e1 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/dfs-dust.js @@ -40,6 +40,9 @@ }, 'fmt_time': function (v) { + if (v < 0) { + return "unknown"; + } var s = Math.floor(v / 1000), h = Math.floor(s / 3600); s -= h * 3600; var m = Math.floor(s / 60);