Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-11409. DatanodeInfo getNetworkLocation and setNetworkLocation shoud use volatile instead of synchronized. Contributed by Chen Liang.

This commit is contained in:
Xiaoyu Yao 2017-02-14 12:52:34 -08:00
parent 0cf5993712
commit aaf2713235
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
View File

@ -51,7 +51,7 @@ public class DatanodeInfo extends DatanodeID implements Node {
private long lastUpdate; private long lastUpdate;
private long lastUpdateMonotonic; private long lastUpdateMonotonic;
private int xceiverCount; private int xceiverCount;
private String location = NetworkTopology.DEFAULT_RACK; private volatile String location = NetworkTopology.DEFAULT_RACK;
private String softwareVersion; private String softwareVersion;
private List<String> dependentHostNames = new LinkedList<>(); private List<String> dependentHostNames = new LinkedList<>();
private String upgradeDomain; private String upgradeDomain;
@ -293,11 +293,11 @@ public void setXceiverCount(int xceiverCount) {
/** network location */ /** network location */
@Override @Override
public synchronized String getNetworkLocation() {return location;} public String getNetworkLocation() {return location;}
/** Sets the network location */ /** Sets the network location */
@Override @Override
public synchronized void setNetworkLocation(String location) { public void setNetworkLocation(String location) {
this.location = NodeBase.normalize(location); this.location = NodeBase.normalize(location);
} }