Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

YARN-8860. Federation client intercepter class contains unwanted character. Contributed by Abhishek Modi.

This commit is contained in:
Giovanni Matteo Fumarola 2018-11-16 10:23:06 -08:00
parent 3420ddd0f8
commit abd6d48c46
2 changed files with 60 additions and 60 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java
View File

@ -304,19 +304,19 @@ public class FederationClientInterceptor
* *
* Base scenarios: * Base scenarios:
* *
* The Client submits an application to the Router. • The Router selects one * The Client submits an application to the Router. The Router selects one
* SubCluster to forward the request. • The Router inserts a tuple into * SubCluster to forward the request. The Router inserts a tuple into
* StateStore with the selected SubCluster (e.g. SC1) and the appId. • The * StateStore with the selected SubCluster (e.g. SC1) and the appId. The
* State Store replies with the selected SubCluster (e.g. SC1). • The Router * State Store replies with the selected SubCluster (e.g. SC1). The Router
* submits the request to the selected SubCluster. * submits the request to the selected SubCluster.
* *
* In case of State Store failure: * In case of State Store failure:
* *
* The client submits an application to the Router. • The Router selects one * The client submits an application to the Router. The Router selects one
* SubCluster to forward the request. • The Router inserts a tuple into State * SubCluster to forward the request. The Router inserts a tuple into State
* Store with the selected SubCluster (e.g. SC1) and the appId. • Due to the * Store with the selected SubCluster (e.g. SC1) and the appId. Due to the
* State Store down the Router times out and it will retry depending on the * State Store down the Router times out and it will retry depending on the
* FederationFacade settings. • The Router replies to the client with an error * FederationFacade settings. The Router replies to the client with an error
* message. * message.
* *
* If State Store fails after inserting the tuple: identical behavior as * If State Store fails after inserting the tuple: identical behavior as
@ -326,26 +326,26 @@ public class FederationClientInterceptor
* *
* Scenario 1 – Crash before submission to the ResourceManager * Scenario 1 – Crash before submission to the ResourceManager
* *
* The Client submits an application to the Router. • The Router selects one * The Client submits an application to the Router. The Router selects one
* SubCluster to forward the request. • The Router inserts a tuple into State * SubCluster to forward the request. The Router inserts a tuple into State
* Store with the selected SubCluster (e.g. SC1) and the appId. • The Router * Store with the selected SubCluster (e.g. SC1) and the appId. The Router
* crashes. • The Client timeouts and resubmits the application. • The Router * crashes. The Client timeouts and resubmits the application. The Router
* selects one SubCluster to forward the request. • The Router inserts a tuple * selects one SubCluster to forward the request. The Router inserts a tuple
* into State Store with the selected SubCluster (e.g. SC2) and the appId. • * into State Store with the selected SubCluster (e.g. SC2) and the appId.
* Because the tuple is already inserted in the State Store, it returns the * Because the tuple is already inserted in the State Store, it returns the
* previous selected SubCluster (e.g. SC1). • The Router submits the request * previous selected SubCluster (e.g. SC1). The Router submits the request
* to the selected SubCluster (e.g. SC1). * to the selected SubCluster (e.g. SC1).
* *
* Scenario 2 – Crash after submission to the ResourceManager * Scenario 2 – Crash after submission to the ResourceManager
* *
* • The Client submits an application to the Router. • The Router selects one * The Client submits an application to the Router. The Router selects one
* SubCluster to forward the request. • The Router inserts a tuple into State * SubCluster to forward the request. The Router inserts a tuple into State
* Store with the selected SubCluster (e.g. SC1) and the appId. • The Router * Store with the selected SubCluster (e.g. SC1) and the appId. The Router
* submits the request to the selected SubCluster. • The Router crashes. • The * submits the request to the selected SubCluster. The Router crashes. The
* Client timeouts and resubmit the application. • The Router selects one * Client timeouts and resubmit the application. The Router selects one
* SubCluster to forward the request. • The Router inserts a tuple into State * SubCluster to forward the request. The Router inserts a tuple into State
* Store with the selected SubCluster (e.g. SC2) and the appId. • The State * Store with the selected SubCluster (e.g. SC2) and the appId. The State
* Store replies with the selected SubCluster (e.g. SC1). • The Router submits * Store replies with the selected SubCluster (e.g. SC1). The Router submits
* the request to the selected SubCluster (e.g. SC1). When a client re-submits * the request to the selected SubCluster (e.g. SC1). When a client re-submits
* the same application to the same RM, it does not raise an exception and * the same application to the same RM, it does not raise an exception and
* replies with operation successful message. * replies with operation successful message.
@ -354,14 +354,14 @@ public class FederationClientInterceptor
* *
* In case of ResourceManager failure: * In case of ResourceManager failure:
* *
* The Client submits an application to the Router. • The Router selects one * The Client submits an application to the Router. The Router selects one
* SubCluster to forward the request. • The Router inserts a tuple into State * SubCluster to forward the request. The Router inserts a tuple into State
* Store with the selected SubCluster (e.g. SC1) and the appId. • The Router * Store with the selected SubCluster (e.g. SC1) and the appId. The Router
* submits the request to the selected SubCluster. • The entire SubCluster is * submits the request to the selected SubCluster. The entire SubCluster is
* down – all the RMs in HA or the master RM is not reachable. • The Router * down – all the RMs in HA or the master RM is not reachable. The Router
* times out. • The Router selects a new SubCluster to forward the request. • * times out. The Router selects a new SubCluster to forward the request.
* The Router update a tuple into State Store with the selected SubCluster * The Router update a tuple into State Store with the selected SubCluster
* (e.g. SC2) and the appId. • The State Store replies with OK answer. • The * (e.g. SC2) and the appId. The State Store replies with OK answer. The
* Router submits the request to the selected SubCluster (e.g. SC2). * Router submits the request to the selected SubCluster (e.g. SC2).
*/ */
@Override @Override

60
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java
View File

@ -325,19 +325,19 @@ public class FederationInterceptorREST extends AbstractRESTRequestInterceptor {
* <p> * <p>
* Base scenarios: * Base scenarios:
* <p> * <p>
* The Client submits an application to the Router. • The Router selects one * The Client submits an application to the Router. The Router selects one
* SubCluster to forward the request. • The Router inserts a tuple into * SubCluster to forward the request. The Router inserts a tuple into
* StateStore with the selected SubCluster (e.g. SC1) and the appId. • The * StateStore with the selected SubCluster (e.g. SC1) and the appId. The
* State Store replies with the selected SubCluster (e.g. SC1). • The Router * State Store replies with the selected SubCluster (e.g. SC1). The Router
* submits the request to the selected SubCluster. * submits the request to the selected SubCluster.
* <p> * <p>
* In case of State Store failure: * In case of State Store failure:
* <p> * <p>
* The client submits an application to the Router. • The Router selects one * The client submits an application to the Router. The Router selects one
* SubCluster to forward the request. • The Router inserts a tuple into State * SubCluster to forward the request. The Router inserts a tuple into State
* Store with the selected SubCluster (e.g. SC1) and the appId. • Due to the * Store with the selected SubCluster (e.g. SC1) and the appId. Due to the
* State Store down the Router times out and it will retry depending on the * State Store down the Router times out and it will retry depending on the
* FederationFacade settings. • The Router replies to the client with an error * FederationFacade settings. The Router replies to the client with an error
* message. * message.
* <p> * <p>
* If State Store fails after inserting the tuple: identical behavior as * If State Store fails after inserting the tuple: identical behavior as
@ -347,26 +347,26 @@ public class FederationInterceptorREST extends AbstractRESTRequestInterceptor {
* <p> * <p>
* Scenario 1 – Crash before submission to the ResourceManager * Scenario 1 – Crash before submission to the ResourceManager
* <p> * <p>
* The Client submits an application to the Router. • The Router selects one * The Client submits an application to the Router. The Router selects one
* SubCluster to forward the request. • The Router inserts a tuple into State * SubCluster to forward the request. The Router inserts a tuple into State
* Store with the selected SubCluster (e.g. SC1) and the appId. • The Router * Store with the selected SubCluster (e.g. SC1) and the appId. The Router
* crashes. • The Client timeouts and resubmits the application. • The Router * crashes. The Client timeouts and resubmits the application. The Router
* selects one SubCluster to forward the request. • The Router inserts a tuple * selects one SubCluster to forward the request. The Router inserts a tuple
* into State Store with the selected SubCluster (e.g. SC2) and the appId. • * into State Store with the selected SubCluster (e.g. SC2) and the appId.
* Because the tuple is already inserted in the State Store, it returns the * Because the tuple is already inserted in the State Store, it returns the
* previous selected SubCluster (e.g. SC1). • The Router submits the request * previous selected SubCluster (e.g. SC1). The Router submits the request
* to the selected SubCluster (e.g. SC1). * to the selected SubCluster (e.g. SC1).
* <p> * <p>
* Scenario 2 – Crash after submission to the ResourceManager * Scenario 2 – Crash after submission to the ResourceManager
* <p> * <p>
* • The Client submits an application to the Router. • The Router selects one * The Client submits an application to the Router. The Router selects one
* SubCluster to forward the request. • The Router inserts a tuple into State * SubCluster to forward the request. The Router inserts a tuple into State
* Store with the selected SubCluster (e.g. SC1) and the appId. • The Router * Store with the selected SubCluster (e.g. SC1) and the appId. The Router
* submits the request to the selected SubCluster. • The Router crashes. • The * submits the request to the selected SubCluster. The Router crashes. The
* Client timeouts and resubmit the application. • The Router selects one * Client timeouts and resubmit the application. The Router selects one
* SubCluster to forward the request. • The Router inserts a tuple into State * SubCluster to forward the request. The Router inserts a tuple into State
* Store with the selected SubCluster (e.g. SC2) and the appId. • The State * Store with the selected SubCluster (e.g. SC2) and the appId. The State
* Store replies with the selected SubCluster (e.g. SC1). • The Router submits * Store replies with the selected SubCluster (e.g. SC1). The Router submits
* the request to the selected SubCluster (e.g. SC1). When a client re-submits * the request to the selected SubCluster (e.g. SC1). When a client re-submits
* the same application to the same RM, it does not raise an exception and * the same application to the same RM, it does not raise an exception and
* replies with operation successful message. * replies with operation successful message.
@ -375,14 +375,14 @@ public class FederationInterceptorREST extends AbstractRESTRequestInterceptor {
* <p> * <p>
* In case of ResourceManager failure: * In case of ResourceManager failure:
* <p> * <p>
* The Client submits an application to the Router. • The Router selects one * The Client submits an application to the Router. The Router selects one
* SubCluster to forward the request. • The Router inserts a tuple into State * SubCluster to forward the request. The Router inserts a tuple into State
* Store with the selected SubCluster (e.g. SC1) and the appId. • The Router * Store with the selected SubCluster (e.g. SC1) and the appId. The Router
* submits the request to the selected SubCluster. • The entire SubCluster is * submits the request to the selected SubCluster. The entire SubCluster is
* down – all the RMs in HA or the master RM is not reachable. • The Router * down – all the RMs in HA or the master RM is not reachable. The Router
* times out. • The Router selects a new SubCluster to forward the request. • * times out. The Router selects a new SubCluster to forward the request.
* The Router update a tuple into State Store with the selected SubCluster * The Router update a tuple into State Store with the selected SubCluster
* (e.g. SC2) and the appId. • The State Store replies with OK answer. • The * (e.g. SC2) and the appId. The State Store replies with OK answer. The
* Router submits the request to the selected SubCluster (e.g. SC2). * Router submits the request to the selected SubCluster (e.g. SC2).
*/ */
@Override @Override