From abe45f59acd21989afa4d1729bd06a90d05dfebe Mon Sep 17 00:00:00 2001
From: Aaron Myers <atm@apache.org>
Date: Tue, 1 Nov 2011 17:59:53 +0000
Subject: [PATCH] HDFS-2526. (Client)NamenodeProtocolTranslatorR23 do not need
 to keep a reference to rpcProxyWithoutRetry (atm)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1196171 13f79535-47bb-0310-9956-ffa450edef68
---
 hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt            |  3 +++
 .../ClientNamenodeProtocolTranslatorR23.java           | 10 ++--------
 .../NamenodeProtocolTranslatorR23.java                 | 10 ++--------
 3 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
index 6096ec31590..d3edf1c810d 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
+++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
@@ -85,6 +85,9 @@ Trunk (unreleased changes)
 
     HDFS-2497 Fix TestBackupNode failure. (suresh)
 
+    HDFS-2526. (Client)NamenodeProtocolTranslatorR23 do not need to keep a
+               reference to rpcProxyWithoutRetry (atm)
+
 Release 0.23.0 - 2011-11-01 
 
   INCOMPATIBLE CHANGES
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeProtocolTranslatorR23.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeProtocolTranslatorR23.java
index aa1da0a6d4a..d9a5525670d 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeProtocolTranslatorR23.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeProtocolTranslatorR23.java
@@ -79,7 +79,6 @@ import org.apache.hadoop.hdfs.protocol.HdfsConstants;
 @InterfaceStability.Stable
 public class ClientNamenodeProtocolTranslatorR23 implements
     ClientProtocol, Closeable {
-  final private ClientNamenodeWireProtocol rpcProxyWithoutRetry;
   final private ClientNamenodeWireProtocol rpcProxy;
 
   private static ClientNamenodeWireProtocol createNamenode(
@@ -118,16 +117,11 @@ public class ClientNamenodeProtocolTranslatorR23 implements
 
   public ClientNamenodeProtocolTranslatorR23(InetSocketAddress nameNodeAddr,
       Configuration conf, UserGroupInformation ugi) throws IOException {
-    rpcProxyWithoutRetry = createNamenode(nameNodeAddr, conf, ugi);
-    rpcProxy = createNamenodeWithRetry(rpcProxyWithoutRetry);
-  }
-
-  public Object getProxyWithoutRetry() {
-    return rpcProxyWithoutRetry;
+    rpcProxy = createNamenodeWithRetry(createNamenode(nameNodeAddr, conf, ugi));
   }
 
   public void close() {
-    RPC.stopProxy(rpcProxyWithoutRetry);
+    RPC.stopProxy(rpcProxy);
   }
 
   @Override
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/NamenodeProtocolTranslatorR23.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/NamenodeProtocolTranslatorR23.java
index 401587e6537..11589756af4 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/NamenodeProtocolTranslatorR23.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/NamenodeProtocolTranslatorR23.java
@@ -57,7 +57,6 @@ import org.apache.hadoop.security.UserGroupInformation;
 @InterfaceStability.Stable
 public class NamenodeProtocolTranslatorR23 implements
     NamenodeProtocol, Closeable {
-  final private NamenodeWireProtocol rpcProxyWithoutRetry;
   final private NamenodeWireProtocol rpcProxy;
 
   private static NamenodeWireProtocol createNamenode(
@@ -97,16 +96,11 @@ public class NamenodeProtocolTranslatorR23 implements
 
   public NamenodeProtocolTranslatorR23(InetSocketAddress nameNodeAddr,
       Configuration conf, UserGroupInformation ugi) throws IOException {
-    rpcProxyWithoutRetry = createNamenode(nameNodeAddr, conf, ugi);
-    rpcProxy = createNamenodeWithRetry(rpcProxyWithoutRetry);
-  }
-
-  public Object getProxyWithoutRetry() {
-    return rpcProxyWithoutRetry;
+    rpcProxy = createNamenodeWithRetry(createNamenode(nameNodeAddr, conf, ugi));
   }
 
   public void close() {
-    RPC.stopProxy(rpcProxyWithoutRetry);
+    RPC.stopProxy(rpcProxy);
   }
 
   @Override