diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java index 8c42cdf92bd..0a949fed827 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java @@ -318,6 +318,12 @@ protected InodeTree(final Configuration config, final String viewName) String src = key.substring(mtPrefix.length()); if (src.startsWith(linkPrefix)) { src = src.substring(linkPrefix.length()); + if (src.equals(SlashPath.toString())) { + throw new UnsupportedFileSystemException("Unexpected mount table " + + "link entry '" + key + "'. " + + Constants.CONFIG_VIEWFS_LINK_MERGE_SLASH + " is not " + + "supported yet."); + } } else if (src.startsWith(linkMergePrefix)) { // A merge link isMergeLink = true; src = src.substring(linkMergePrefix.length()); diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java index eb48be1967f..025fe678635 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java @@ -43,6 +43,9 @@ import org.apache.hadoop.fs.FsConstants; import org.apache.hadoop.fs.LocatedFileStatus; import org.apache.hadoop.fs.Path; +import org.apache.hadoop.fs.RemoteIterator; +import org.apache.hadoop.fs.UnsupportedFileSystemException; +import org.apache.hadoop.fs.permission.AclEntry; import org.apache.hadoop.fs.permission.AclStatus; import org.apache.hadoop.fs.permission.AclUtil; import org.apache.hadoop.fs.RemoteIterator; @@ -61,6 +64,8 @@ import org.junit.Before; import org.junit.Test; +import static org.hamcrest.CoreMatchers.containsString; +import static org.junit.Assert.*; /** *

@@ -1056,4 +1061,30 @@ public void testDeleteOnExit() throws Exception { viewFs.close(); assertFalse(fsTarget.exists(realTestPath)); } + + public void testConfLinkSlash() throws Exception { + String clusterName = "ClusterX"; + URI viewFsUri = new URI(FsConstants.VIEWFS_SCHEME, clusterName, + "/", null, null); + + Configuration newConf = new Configuration(); + ConfigUtil.addLink(newConf, clusterName, "/", + new Path(targetTestRoot, "/").toUri()); + + String mtPrefix = Constants.CONFIG_VIEWFS_PREFIX + "." + clusterName + "."; + try { + FileSystem.get(viewFsUri, newConf); + fail("ViewFileSystem should error out on mount table entry: " + + mtPrefix + Constants.CONFIG_VIEWFS_LINK + "." + "/"); + } catch (Exception e) { + if (e instanceof UnsupportedFileSystemException) { + String msg = Constants.CONFIG_VIEWFS_LINK_MERGE_SLASH + + " is not supported yet."; + assertThat(e.getMessage(), containsString(msg)); + } else { + fail("Unexpected exception: " + e.getMessage()); + } + } + } + }