From b01efe5cf6e756baae650bc568a764e28ccfa858 Mon Sep 17 00:00:00 2001 From: Steve Loughran Date: Fri, 2 Aug 2019 22:30:48 +0100 Subject: [PATCH] HADOOP-16472. findbugs warning on LocalMetadataStore.ttlTimeProvider sync Contributed by Steve Loughran. Moved the setter and addAncestors to synchronized Change-Id: Ib362c66d1b8c9124eca7db9a44274ac08d0b3be6 --- .../org/apache/hadoop/fs/s3a/s3guard/LocalMetadataStore.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/LocalMetadataStore.java b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/LocalMetadataStore.java index 4ce6a7f9325..1cc4a61e229 100644 --- a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/LocalMetadataStore.java +++ b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/LocalMetadataStore.java @@ -605,12 +605,12 @@ public RenameTracker initiateRenameOperation(final StoreContext storeContext, } @Override - public void setTtlTimeProvider(ITtlTimeProvider ttlTimeProvider) { + public synchronized void setTtlTimeProvider(ITtlTimeProvider ttlTimeProvider) { this.ttlTimeProvider = ttlTimeProvider; } @Override - public void addAncestors(final Path qualifiedPath, + public synchronized void addAncestors(final Path qualifiedPath, @Nullable final BulkOperationState operationState) throws IOException { Collection newDirs = new ArrayList<>();