Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HADOOP-8818. Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. 

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1385374 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 0c53ed4cd1)
This commit is contained in:
Suresh Srinivas 2012-09-16 21:10:39 +00:00 committed by Akira Ajisaka
parent 03afcdd39d
commit b1d497a7de
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-common-project/hadoop-common/CHANGES.txt
View File

@ -1170,6 +1170,9 @@ Release 2.7.3 - UNRELEASED
HADOOP-12792. TestUserGroupInformation#testGetServerSideGroups fails in HADOOP-12792. TestUserGroupInformation#testGetServerSideGroups fails in
chroot (Eric Badger via jlowe) chroot (Eric Badger via jlowe)
HADOOP-8818. Use equals instead == in MD5MD5CRC32FileChecksum
and TFileDumper. (Brandon Li via suresh)
Release 2.7.2 - 2016-01-25 Release 2.7.2 - 2016-01-25
INCOMPATIBLE CHANGES INCOMPATIBLE CHANGES

2
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java
View File

@ -134,7 +134,7 @@ public static MD5MD5CRC32FileChecksum valueOf(Attributes attrs
try { try {
// old versions don't support crcType. // old versions don't support crcType.
if (crcType == null || crcType == "") { if (crcType == null || crcType.equals("")) {
finalCrcType = DataChecksum.Type.CRC32; finalCrcType = DataChecksum.Type.CRC32;
} else { } else {
finalCrcType = DataChecksum.Type.valueOf(crcType); finalCrcType = DataChecksum.Type.valueOf(crcType);

2
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
View File

@ -126,7 +126,7 @@ static public void dumpInfo(String file, PrintStream out, Configuration conf)
dataSizeUncompressed += region.getRawSize(); dataSizeUncompressed += region.getRawSize();
} }
properties.put("Data Block Bytes", Long.toString(dataSize)); properties.put("Data Block Bytes", Long.toString(dataSize));
if (reader.readerBCF.getDefaultCompressionName() != "none") { if (!reader.readerBCF.getDefaultCompressionName().equals("none")) {
properties.put("Data Block Uncompressed Bytes", Long properties.put("Data Block Uncompressed Bytes", Long
.toString(dataSizeUncompressed)); .toString(dataSizeUncompressed));
properties.put("Data Block Compression Ratio", String.format( properties.put("Data Block Compression Ratio", String.format(