From b3f6b641dccb0d59df78855e2951d2cae7dff8ad Mon Sep 17 00:00:00 2001 From: Jian He Date: Fri, 18 Sep 2015 16:42:26 +0800 Subject: [PATCH] YARN-4171. Fix findbugs warnings in YARN-1197 branch. Contributed by Wangda Tan --- hadoop-yarn-project/CHANGES.txt | 2 ++ .../yarn/server/resourcemanager/rmnode/RMNodeStatusEvent.java | 1 + .../resourcemanager/scheduler/SchedulerApplicationAttempt.java | 3 --- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hadoop-yarn-project/CHANGES.txt b/hadoop-yarn-project/CHANGES.txt index c27c897bedc..d1e6bc7935a 100644 --- a/hadoop-yarn-project/CHANGES.txt +++ b/hadoop-yarn-project/CHANGES.txt @@ -900,6 +900,8 @@ Release 2.8.0 - UNRELEASED YARN-4188. Make MoveApplicationAcrossQueues abstract, newInstance static. (Giovanni Matteo Fumarola via cdouglas) + YARN-4171. Fix findbugs warnings in YARN-1197 branch. (Wangda Tan via jianhe) + Release 2.7.2 - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeStatusEvent.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeStatusEvent.java index 8323f3ce9ba..0dbea1a1e16 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeStatusEvent.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeStatusEvent.java @@ -93,6 +93,7 @@ public void setLogAggregationReportsForApps( this.logAggregationReportsForApps = logAggregationReportsForApps; } + @SuppressWarnings("unchecked") public List getNMReportedIncreasedContainers() { return nmReportedIncreasedContainers == null ? Collections.EMPTY_LIST : nmReportedIncreasedContainers; diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java index f064e972f68..005fa71b7c3 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java @@ -478,9 +478,6 @@ private Container updateContainerAndNMToken(RMContainer rmContainer, ContainerType containerType = ContainerType.TASK; // The working knowledge is that masterContainer for AM is null as it // itself is the master container. - RMAppAttempt appAttempt = rmContext.getRMApps() - .get(container.getId().getApplicationAttemptId().getApplicationId()) - .getCurrentAppAttempt(); if (isWaitingForAMContainer(getApplicationId())) { containerType = ContainerType.APPLICATION_MASTER; }