From b4ab7aa110d04934cc63ae98a4db8b295804ba81 Mon Sep 17 00:00:00 2001 From: Jason Lowe Date: Thu, 11 Sep 2014 19:53:25 +0000 Subject: [PATCH] HADOOP-11085. Excessive logging by org.apache.hadoop.util.Progress when value is NaN. Contributed by Mit Desai (cherry picked from commit 581176cdc868b8701a761b5a0d52f771cbba709a) --- hadoop-common-project/hadoop-common/CHANGES.txt | 3 +++ .../src/main/java/org/apache/hadoop/util/Progress.java | 10 +++++----- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index 2d1375f791b..8d03b01f262 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -454,6 +454,9 @@ Release 2.6.0 - UNRELEASED HADOOP-9989. Bug introduced in HADOOP-9374, which parses the -tokenCacheFile as binary file but set it to the configuration as JSON file. (zxu via tucu) + HADOOP-11085. Excessive logging by org.apache.hadoop.util.Progress when + value is NaN (Mit Desai via jlowe) + Release 2.5.1 - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Progress.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Progress.java index e3445b5da6b..3fbc9350f17 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Progress.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Progress.java @@ -162,27 +162,27 @@ public class Progress { public synchronized void set(float progress) { if (Float.isNaN(progress)) { progress = 0; - LOG.warn("Illegal progress value found, progress is Float.NaN. " + + LOG.debug("Illegal progress value found, progress is Float.NaN. " + "Progress will be changed to 0"); } else if (progress == Float.NEGATIVE_INFINITY) { progress = 0; - LOG.warn("Illegal progress value found, progress is " + + LOG.debug("Illegal progress value found, progress is " + "Float.NEGATIVE_INFINITY. Progress will be changed to 0"); } else if (progress < 0) { progress = 0; - LOG.warn("Illegal progress value found, progress is less than 0." + + LOG.debug("Illegal progress value found, progress is less than 0." + " Progress will be changed to 0"); } else if (progress > 1) { progress = 1; - LOG.warn("Illegal progress value found, progress is larger than 1." + + LOG.debug("Illegal progress value found, progress is larger than 1." + " Progress will be changed to 1"); } else if (progress == Float.POSITIVE_INFINITY) { progress = 1; - LOG.warn("Illegal progress value found, progress is " + + LOG.debug("Illegal progress value found, progress is " + "Float.POSITIVE_INFINITY. Progress will be changed to 1"); } this.progress = progress;