Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-9942. Add an HTrace span when refreshing the groups for a username (cmccabe) 

(cherry picked from commit 6e9a582eb1)
This commit is contained in:
Colin Patrick Mccabe 2016-03-11 12:26:40 -08:00
parent 1c96fd0a23
commit b67b5b09a7
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/Groups.java
View File

@ -27,6 +27,8 @@ import java.util.Set;
import java.util.concurrent.ExecutionException; import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeUnit;
import org.apache.htrace.core.TraceScope;
import org.apache.htrace.core.Tracer;
import com.google.common.annotations.VisibleForTesting; import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Ticker; import com.google.common.base.Ticker;
import com.google.common.cache.CacheBuilder; import com.google.common.cache.CacheBuilder;
@ -217,7 +219,20 @@ public class Groups {
*/ */
@Override @Override
public List<String> load(String user) throws Exception { public List<String> load(String user) throws Exception {
List<String> groups = fetchGroupList(user); TraceScope scope = null;
Tracer tracer = Tracer.curThreadTracer();
if (tracer != null) {
scope = tracer.newScope("Groups#fetchGroupList");
scope.addKVAnnotation("user", user);
}
List<String> groups = null;
try {
groups = fetchGroupList(user);
} finally {
if (scope != null) {
scope.close();
}
}
if (groups.isEmpty()) { if (groups.isEmpty()) {
if (isNegativeCacheEnabled()) { if (isNegativeCacheEnabled()) {