Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HADOOP-16775. DistCp reuses the same temp file within the task for different files. 

Contributed by Amir Shenavandeh.

This avoids overwrite consistency issues with S3 and other stores -though
given S3's copy operation is O(data), you are still best of using -direct
when distcp-ing to it.

Change-Id: I8dc9f048ad0cc57ff01543b849da1ce4eaadf8c3
This commit is contained in:
Steve Loughran 2020-01-02 15:36:25 +00:00
parent eca7e14c2f
commit b6dc00f481
No known key found for this signature in database
GPG Key ID: D22CF846DBB162A0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
View File

@ -230,7 +230,8 @@ public class RetriableFileCopyCommand extends RetriableCommand {
Path root = target.equals(targetWorkPath) ? targetWorkPath.getParent() Path root = target.equals(targetWorkPath) ? targetWorkPath.getParent()
: targetWorkPath; : targetWorkPath;
Path tempFile = new Path(root, ".distcp.tmp." + Path tempFile = new Path(root, ".distcp.tmp." +
context.getTaskAttemptID().toString()); context.getTaskAttemptID().toString() +
"." + String.valueOf(System.currentTimeMillis()));
LOG.info("Creating temp file: {}", tempFile); LOG.info("Creating temp file: {}", tempFile);
return tempFile; return tempFile;
} }