YARN-1919. Potential NPE in EmbeddedElectorService#stop. (Tsuyoshi Ozawa via kasha)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-2@1619253 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Karthik Kambatla 2014-08-20 22:14:13 +00:00
parent 8b8fe3a425
commit bf0e9e894d
2 changed files with 11 additions and 2 deletions

View File

@ -205,6 +205,9 @@ Release 2.6.0 - UNRELEASED
YARN-2034. Description for yarn.nodemanager.localizer.cache.target-size-mb
is incorrect (Chen He via jlowe)
YARN-1919. Potential NPE in EmbeddedElectorService#stop.
(Tsuyoshi Ozawa via kasha)
Release 2.5.0 - 2014-08-11
INCOMPATIBLE CHANGES

View File

@ -109,8 +109,14 @@ public class EmbeddedElectorService extends AbstractService
@Override
protected void serviceStop() throws Exception {
elector.quitElection(false);
elector.terminateConnection();
/**
* When error occurs in serviceInit(), serviceStop() can be called.
* We need null check for the case.
*/
if (elector != null) {
elector.quitElection(false);
elector.terminateConnection();
}
super.serviceStop();
}