diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index 914a004ae3d..8d16958749f 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -288,6 +288,8 @@ Release 2.5.0 - UNRELEASED HADOOP-10479. Fix new findbugs warnings in hadoop-minikdc. (Swarnim Kulkarni via wheat9) + HADOOP-10715. Remove public GraphiteSink#setWriter (Babak Behzad via raviprak) + Release 2.4.1 - 2014-06-23 INCOMPATIBLE CHANGES diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/GraphiteSink.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/GraphiteSink.java index b81ed4d80bb..f474d82a98f 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/GraphiteSink.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/GraphiteSink.java @@ -50,10 +50,6 @@ public class GraphiteSink implements MetricsSink, Closeable { private String metricsPrefix = null; private Socket socket = null; - public void setWriter(Writer writer) { - this.writer = writer; - } - @Override public void init(SubsetConfiguration conf) { // Get Graphite host configurations. @@ -68,7 +64,7 @@ public void init(SubsetConfiguration conf) { try { // Open an connection to Graphite server. socket = new Socket(serverHost, serverPort); - setWriter(new OutputStreamWriter(socket.getOutputStream())); + writer = new OutputStreamWriter(socket.getOutputStream()); } catch (Exception e) { throw new MetricsException("Error creating connection, " + serverHost + ":" + serverPort, e); diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestGraphiteMetrics.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestGraphiteMetrics.java index ab89bb8e828..f54c27dc6d9 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestGraphiteMetrics.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestGraphiteMetrics.java @@ -28,15 +28,16 @@ import java.util.List; import java.util.Set; -import static org.mockito.Mockito.*; - import org.apache.hadoop.metrics2.AbstractMetric; import org.apache.hadoop.metrics2.MetricsException; import org.apache.hadoop.metrics2.MetricsRecord; import org.apache.hadoop.metrics2.MetricsTag; import org.apache.hadoop.metrics2.sink.GraphiteSink; import org.junit.Test; + +import static org.mockito.Mockito.*; import org.mockito.ArgumentCaptor; +import org.mockito.internal.util.reflection.Whitebox; public class TestGraphiteMetrics { private AbstractMetric makeMetric(String name, Number value) { @@ -57,14 +58,13 @@ public void testPutMetrics() { metrics.add(makeMetric("foo2", 2.25)); MetricsRecord record = new MetricsRecordImpl(MsInfo.Context, (long) 10000, tags, metrics); - OutputStreamWriter writer = mock(OutputStreamWriter.class); + OutputStreamWriter mockWriter = mock(OutputStreamWriter.class); ArgumentCaptor argument = ArgumentCaptor.forClass(String.class); - - sink.setWriter(writer); + Whitebox.setInternalState(sink, "writer", mockWriter); sink.putMetrics(record); try { - verify(writer).write(argument.capture()); + verify(mockWriter).write(argument.capture()); } catch (IOException e) { e.printStackTrace(); } @@ -89,14 +89,13 @@ public void testPutMetrics2() { metrics.add(makeMetric("foo2", 2)); MetricsRecord record = new MetricsRecordImpl(MsInfo.Context, (long) 10000, tags, metrics); - OutputStreamWriter writer = mock(OutputStreamWriter.class); + OutputStreamWriter mockWriter = mock(OutputStreamWriter.class); ArgumentCaptor argument = ArgumentCaptor.forClass(String.class); - - sink.setWriter(writer); + Whitebox.setInternalState(sink, "writer", mockWriter); sink.putMetrics(record); try { - verify(writer).write(argument.capture()); + verify(mockWriter).write(argument.capture()); } catch (IOException e) { e.printStackTrace(); } @@ -122,26 +121,26 @@ public void testCloseAndWrite() throws IOException { OutputStreamWriter writer = mock(OutputStreamWriter.class); - sink.setWriter(writer); + Whitebox.setInternalState(sink, "writer", writer); sink.close(); sink.putMetrics(record); } @Test public void testClose(){ - GraphiteSink sink = new GraphiteSink(); - Writer mockWriter = mock(Writer.class); - sink.setWriter(mockWriter); - try { - sink.close(); - } catch (IOException ioe) { - ioe.printStackTrace(); - } + GraphiteSink sink = new GraphiteSink(); + Writer mockWriter = mock(Writer.class); + Whitebox.setInternalState(sink, "writer", mockWriter); + try { + sink.close(); + } catch (IOException ioe) { + ioe.printStackTrace(); + } - try { - verify(mockWriter).close(); - } catch (IOException ioe) { - ioe.printStackTrace(); - } + try { + verify(mockWriter).close(); + } catch (IOException ioe) { + ioe.printStackTrace(); + } } }