From c139fe7a37ede2f963e11270d5edce03555bf2e7 Mon Sep 17 00:00:00 2001 From: Sunil G Date: Mon, 25 Feb 2019 15:28:45 +0530 Subject: [PATCH] YARN-9168. DistributedShell client timeout should be -1 by default. Contributed by Zhankun Tang. (cherry picked from commit 6cec90653dc2ae60a10262745997ea91dd872a8b) --- .../applications/distributedshell/Client.java | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java index fd04997446e..70dd546a67f 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java @@ -880,14 +880,17 @@ else if (YarnApplicationState.KILLED == state + " YarnState=" + state.toString() + ", DSFinalStatus=" + dsStatus.toString() + ". Breaking monitoring loop"); return false; - } - - if (System.currentTimeMillis() > (clientStartTime + clientTimeout)) { - LOG.info("Reached client specified timeout for application. Killing application"); - forceKillApplication(appId); - return false; } - } + + // The value equal or less than 0 means no timeout + if (clientTimeout > 0 + && System.currentTimeMillis() > (clientStartTime + clientTimeout)) { + LOG.info("Reached client specified timeout for application. " + + "Killing application"); + forceKillApplication(appId); + return false; + } + } }