YARN-9336. JobHistoryServer leaks CLOSE_WAIT tcp connections when using LogAggregationIndexedFileController. Contributed by Tarun Parimi.

This commit is contained in:
Rohith Sharma K S 2019-03-12 20:57:27 +05:30
parent daf4660eeb
commit c24af4b0d6
1 changed files with 30 additions and 30 deletions

View File

@ -202,7 +202,7 @@ public class IndexedFileAggregatedLogsBlock extends LogAggregationHtmlBlock {
Decompressor decompressor = compressName.getDecompressor();
FileContext fileContext = FileContext.getFileContext(
thisNodeFile.getPath().toUri(), conf);
FSDataInputStream fsin = fileContext.open(thisNodeFile.getPath());
try (FSDataInputStream fsin = fileContext.open(thisNodeFile.getPath())) {
int bufferSize = 65536;
for (IndexedFileLogMeta candidate : candidates) {
if (candidate.getLastModifiedTime() < startTime
@ -219,9 +219,8 @@ public class IndexedFileAggregatedLogsBlock extends LogAggregationHtmlBlock {
long logLength = candidate.getFileSize();
html.pre().__("\n\n").__();
html.p().__("Log Type: " + candidate.getFileName()).__();
html.p().__(
"Log Upload Time: " + Times.format(candidate.getLastModifiedTime()))
.__();
html.p().__("Log Upload Time: " +
Times.format(candidate.getLastModifiedTime())).__();
html.p().__("Log Length: " + Long.toString(logLength)).__();
long[] range = checkParseRange(html, start, end, startTime, endTime,
@ -236,6 +235,7 @@ public class IndexedFileAggregatedLogsBlock extends LogAggregationHtmlBlock {
IOUtils.closeQuietly(in);
}
}
}
return foundLog;
}