From c936562c724d9b4fdd3ed61cdd9ef46359f97fc2 Mon Sep 17 00:00:00 2001 From: Konstantin V Shvachko Date: Mon, 24 Dec 2018 09:39:20 -0800 Subject: [PATCH] HDFS-14170. [SBN read] Fix checkstyle warnings related to SBN reads. Contributed by Konstantin V Shvachko. --- .../src/main/java/org/apache/hadoop/ipc/RPC.java | 2 +- .../hdfs/server/namenode/ha/ObserverReadProxyProvider.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java index 5440780c466..0be5cb5fc0f 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java @@ -591,7 +591,7 @@ public class RPC { /** * Get a protocol proxy that contains a proxy connection to a remote server - * and a set of methods that are supported by the server + * and a set of methods that are supported by the server. * * @param protocol protocol * @param clientVersion client's version diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java index 96932a7b5c4..75405085f2a 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java @@ -110,7 +110,7 @@ public class ObserverReadProxyProvider public ObserverReadProxyProvider( Configuration conf, URI uri, Class xface, HAProxyFactory factory) { this(conf, uri, xface, factory, - new ConfiguredFailoverProxyProvider<>(conf, uri, xface,factory)); + new ConfiguredFailoverProxyProvider<>(conf, uri, xface, factory)); } @SuppressWarnings("unchecked") @@ -144,7 +144,7 @@ public class ObserverReadProxyProvider combinedInfo.append(']'); T wrappedProxy = (T) Proxy.newProxyInstance( ObserverReadInvocationHandler.class.getClassLoader(), - new Class[] { xface }, new ObserverReadInvocationHandler()); + new Class[] {xface}, new ObserverReadInvocationHandler()); combinedProxy = new ProxyInfo<>(wrappedProxy, combinedInfo.toString()); // TODO : make this configurable or remove this variable this.observerReadEnabled = true; @@ -232,7 +232,7 @@ public class ObserverReadProxyProvider /** * An InvocationHandler to handle incoming requests. This class's invoke * method contains the primary logic for redirecting to observers. - * + * * If observer reads are enabled, attempt to send read operations to the * current proxy. If it is not an observer, or the observer fails, adjust * the current proxy and retry on the next one. If all proxies are tried