Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-1774. Small optimization to FSDataset. Contributed by Uma Maheswara Rao G 

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1148894 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Eli Collins 2011-07-20 18:52:57 +00:00
parent 54c5bf2b8c
commit cda43d71be
2 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hdfs/CHANGES.txt
View File

@ -579,6 +579,8 @@ Trunk (unreleased changes)
and Random object creation to DFSUtil; move DFSClient.stringifyToken(..) and Random object creation to DFSUtil; move DFSClient.stringifyToken(..)
to DelegationTokenIdentifier. (szetszwo) to DelegationTokenIdentifier. (szetszwo)
HDFS-1774. Small optimization to FSDataset. (Uma Maheswara Rao G via eli)
OPTIMIZATIONS OPTIMIZATIONS
HDFS-1458. Improve checkpoint performance by avoiding unnecessary image HDFS-1458. Improve checkpoint performance by avoiding unnecessary image

15
hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java
View File

@ -99,23 +99,16 @@ public class FSDataset implements FSConstants, FSDatasetInterface {
} }
} else { } else {
File[] files = FileUtil.listFiles(dir); File[] files = FileUtil.listFiles(dir);
int numChildren = 0; List<FSDir> dirList = new ArrayList<FSDir>();
for (int idx = 0; idx < files.length; idx++) { for (int idx = 0; idx < files.length; idx++) {
if (files[idx].isDirectory()) { if (files[idx].isDirectory()) {
numChildren++; dirList.add(new FSDir(files[idx]));
} else if (Block.isBlockFilename(files[idx])) { } else if (Block.isBlockFilename(files[idx])) {
numBlocks++; numBlocks++;
} }
} }
if (numChildren > 0) { if (dirList.size() > 0) {
children = new FSDir[numChildren]; children = dirList.toArray(new FSDir[dirList.size()]);
int curdir = 0;
for (int idx = 0; idx < files.length; idx++) {
if (files[idx].isDirectory()) {
children[curdir] = new FSDir(files[idx]);
curdir++;
}
}
} }
} }
} }