Apache/hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-15460. TestFileCreation#testServerDefaultsWithMinimalCaching fails intermittently. (#2406)

Browse Source
This commit is contained in:
Ahmed Hussein 2020-10-27 20:56:40 -05:00 committed by GitHub
parent 98097b8f19
commit d0c786db4d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
View File

@ -239,9 +239,8 @@ public void testServerDefaultsWithCaching()
* Test that server defaults are updated on the client after cache expiration. * Test that server defaults are updated on the client after cache expiration.
*/ */
@Test @Test
public void testServerDefaultsWithMinimalCaching() public void testServerDefaultsWithMinimalCaching() throws Exception {
throws IOException, InterruptedException { // Create cluster with an explicit block size param.
// Create cluster with an explicit block size param
Configuration clusterConf = new HdfsConfiguration(); Configuration clusterConf = new HdfsConfiguration();
long originalBlockSize = DFS_BLOCK_SIZE_DEFAULT * 2; long originalBlockSize = DFS_BLOCK_SIZE_DEFAULT * 2;
clusterConf.setLong(DFS_BLOCK_SIZE_KEY, originalBlockSize); clusterConf.setLong(DFS_BLOCK_SIZE_KEY, originalBlockSize);
@ -273,10 +272,17 @@ public void testServerDefaultsWithMinimalCaching()
defaults.getDefaultStoragePolicyId()); defaults.getDefaultStoragePolicyId());
doReturn(newDefaults).when(spyNamesystem).getServerDefaults(); doReturn(newDefaults).when(spyNamesystem).getServerDefaults();
Thread.sleep(1); // Verify that the value is updated correctly. Wait for 3 seconds.
defaults = dfsClient.getServerDefaults(); GenericTestUtils.waitFor(()->{
// Value is updated correctly try {
assertEquals(updatedDefaultBlockSize, defaults.getBlockSize()); FsServerDefaults currDef = dfsClient.getServerDefaults();
return (currDef.getBlockSize() == updatedDefaultBlockSize);
} catch (IOException e) {
// do nothing;
return false;
}
}, 1, 3000);
} finally { } finally {
cluster.shutdown(); cluster.shutdown();
} }