From d1d6bb70f4de66f393f2d5c52d4611b1f87b152e Mon Sep 17 00:00:00 2001 From: Karthik Kambatla Date: Wed, 4 Jun 2014 21:11:09 +0000 Subject: [PATCH] YARN-2061. Revisit logging levels in ZKRMStateStore. (Ray Chiang via kasha) git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1600498 13f79535-47bb-0310-9956-ffa450edef68 --- hadoop-yarn-project/CHANGES.txt | 2 ++ .../resourcemanager/recovery/ZKRMStateStore.java | 14 +++++++------- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hadoop-yarn-project/CHANGES.txt b/hadoop-yarn-project/CHANGES.txt index ba1bcf1b88d..bab764b37b3 100644 --- a/hadoop-yarn-project/CHANGES.txt +++ b/hadoop-yarn-project/CHANGES.txt @@ -135,6 +135,8 @@ Release 2.5.0 - UNRELEASED YARN-1913. With Fair Scheduler, cluster can logjam when all resources are consumed by AMs (Wei Yan via Sandy Ryza) + YARN-2061. Revisit logging levels in ZKRMStateStore. (Ray Chiang via kasha) + OPTIMIZATIONS BUG FIXES diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java index 6026e94f9b8..c5016e1397a 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java @@ -546,7 +546,7 @@ public class ZKRMStateStore extends RMStateStore { appState.attempts.put(attemptState.getAttemptId(), attemptState); } } - LOG.info("Done Loading applications from ZK state store"); + LOG.debug("Done Loading applications from ZK state store"); } @Override @@ -579,7 +579,7 @@ public class ZKRMStateStore extends RMStateStore { } else { createWithRetries(nodeUpdatePath, appStateData, zkAcl, CreateMode.PERSISTENT); - LOG.info(appId + " znode didn't exist. Created a new znode to" + LOG.debug(appId + " znode didn't exist. Created a new znode to" + " update the application state."); } } @@ -622,7 +622,7 @@ public class ZKRMStateStore extends RMStateStore { } else { createWithRetries(nodeUpdatePath, attemptStateData, zkAcl, CreateMode.PERSISTENT); - LOG.info(appAttemptId + " znode didn't exist. Created a new znode to" + LOG.debug(appAttemptId + " znode didn't exist. Created a new znode to" + " update the application attempt state."); } } @@ -671,7 +671,7 @@ public class ZKRMStateStore extends RMStateStore { if (existsWithRetries(nodeRemovePath, true) != null) { opList.add(Op.delete(nodeRemovePath, -1)); } else { - LOG.info("Attempted to delete a non-existing znode " + nodeRemovePath); + LOG.debug("Attempted to delete a non-existing znode " + nodeRemovePath); } doMultiWithRetries(opList); } @@ -688,7 +688,7 @@ public class ZKRMStateStore extends RMStateStore { // in case znode doesn't exist addStoreOrUpdateOps( opList, rmDTIdentifier, renewDate, latestSequenceNumber, false); - LOG.info("Attempted to update a non-existing znode " + nodeRemovePath); + LOG.debug("Attempted to update a non-existing znode " + nodeRemovePath); } else { // in case znode exists addStoreOrUpdateOps( @@ -770,7 +770,7 @@ public class ZKRMStateStore extends RMStateStore { if (existsWithRetries(nodeRemovePath, true) != null) { doMultiWithRetries(Op.delete(nodeRemovePath, -1)); } else { - LOG.info("Attempted to delete a non-existing znode " + nodeRemovePath); + LOG.debug("Attempted to delete a non-existing znode " + nodeRemovePath); } } @@ -823,7 +823,7 @@ public class ZKRMStateStore extends RMStateStore { case Expired: // the connection got terminated because of session timeout // call listener to reconnect - LOG.info("Session expired"); + LOG.info("ZKRMStateStore Session expired"); createConnection(); break; default: