Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-10657. testAclCLI.xml setfacl test should expect mask r-x. (John Zhuge via Yongjun Zhang)

This commit is contained in:
Yongjun Zhang 2016-09-12 21:25:06 -07:00
parent 72dfb048a9
commit d2466ec3e0
2 changed files with 61 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/cli/util/ExactLineComparator.java Normal file
View File

@ -0,0 +1,44 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.hadoop.cli.util;
import java.util.StringTokenizer;
/**
* Comparator for the Command line tests.
*
* This comparator searches for an exact line as 'expected'
* in the string 'actual' and returns true if found
*
*/
public class ExactLineComparator extends ComparatorBase {
@Override
public boolean compare(String actual, String expected) {
boolean success = false;
StringTokenizer tokenizer = new StringTokenizer(actual, "\n\r");
while (tokenizer.hasMoreTokens() && !success) {
String actualToken = tokenizer.nextToken();
success = actualToken.equals(expected);
}
return success;
}
}

34
hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml
View File

@ -679,63 +679,63 @@
</cleanup-commands> </cleanup-commands>
<comparators> <comparators>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output># file: /dir1/dir2</expected-output> <expected-output># file: /dir1/dir2</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output># owner: USERNAME</expected-output> <expected-output># owner: USERNAME</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output># group: supergroup</expected-output> <expected-output># group: supergroup</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output>user::rwx</expected-output> <expected-output>user::rwx</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output>user:charlie:r-x</expected-output> <expected-output>user:charlie:r-x</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output>group::r-x</expected-output> <expected-output>group::r-x</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>RegexpComparator</type>
<expected-output>group:admin:rwx</expected-output> <expected-output>^group:admin:rwx\b.*</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output>mask::rwx</expected-output> <expected-output>mask::r-x</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output>default:user::rwx</expected-output> <expected-output>default:user::rwx</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output>default:user:charlie:r-x</expected-output> <expected-output>default:user:charlie:r-x</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output>default:group::r-x</expected-output> <expected-output>default:group::r-x</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output>default:group:admin:rwx</expected-output> <expected-output>default:group:admin:rwx</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output>default:mask::rwx</expected-output> <expected-output>default:mask::rwx</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output>default:other::r-x</expected-output> <expected-output>default:other::r-x</expected-output>
</comparator> </comparator>
<comparator> <comparator>
<type>SubstringComparator</type> <type>ExactLineComparator</type>
<expected-output>other::r-x</expected-output> <expected-output>other::r-x</expected-output>
</comparator> </comparator>
</comparators> </comparators>