HDFS-10694. processReport() should print blockReportId in each log message. Contributed by Yuanbo Liu.
(cherry picked from commit 10e84c6a6e
)
This commit is contained in:
parent
e1845faeda
commit
d46f5ca7e2
|
@ -1913,6 +1913,8 @@ public class BlockManager implements BlockStatsMXBean {
|
|||
final long endTime;
|
||||
DatanodeDescriptor node;
|
||||
Collection<Block> invalidatedBlocks = Collections.emptyList();
|
||||
String strBlockReportId =
|
||||
context != null ? Long.toHexString(context.getReportId()) : "";
|
||||
|
||||
try {
|
||||
node = datanodeManager.getDatanode(nodeID);
|
||||
|
@ -1931,9 +1933,10 @@ public class BlockManager implements BlockStatsMXBean {
|
|||
}
|
||||
if (namesystem.isInStartupSafeMode()
|
||||
&& storageInfo.getBlockReportCount() > 0) {
|
||||
blockLog.info("BLOCK* processReport: "
|
||||
blockLog.info("BLOCK* processReport 0x{}: "
|
||||
+ "discarded non-initial block report from {}"
|
||||
+ " because namenode still in startup phase", nodeID);
|
||||
+ " because namenode still in startup phase",
|
||||
strBlockReportId, nodeID);
|
||||
blockReportLeaseManager.removeLease(node);
|
||||
return !node.hasStaleStorages();
|
||||
}
|
||||
|
@ -1947,12 +1950,14 @@ public class BlockManager implements BlockStatsMXBean {
|
|||
if (storageInfo.getBlockReportCount() == 0) {
|
||||
// The first block report can be processed a lot more efficiently than
|
||||
// ordinary block reports. This shortens restart times.
|
||||
LOG.info("Processing first storage report for " +
|
||||
storageInfo.getStorageID() + " from datanode " +
|
||||
blockLog.info("BLOCK* processReport 0x{}: Processing first "
|
||||
+ "storage report for {} from datanode {}",
|
||||
strBlockReportId,
|
||||
storageInfo.getStorageID(),
|
||||
nodeID.getDatanodeUuid());
|
||||
processFirstBlockReport(storageInfo, newReport);
|
||||
} else {
|
||||
invalidatedBlocks = processReport(storageInfo, newReport);
|
||||
invalidatedBlocks = processReport(storageInfo, newReport, context);
|
||||
}
|
||||
|
||||
storageInfo.receivedBlockReport();
|
||||
|
@ -1988,8 +1993,8 @@ public class BlockManager implements BlockStatsMXBean {
|
|||
}
|
||||
|
||||
for (Block b : invalidatedBlocks) {
|
||||
blockLog.debug("BLOCK* processReport: {} on node {} size {} does not " +
|
||||
"belong to any file", b, node, b.getNumBytes());
|
||||
blockLog.debug("BLOCK* processReport 0x{}: {} on node {} size {} does not"
|
||||
+ " belong to any file", strBlockReportId, b, node, b.getNumBytes());
|
||||
}
|
||||
|
||||
// Log the block report processing stats from Namenode perspective
|
||||
|
@ -1997,10 +2002,10 @@ public class BlockManager implements BlockStatsMXBean {
|
|||
if (metrics != null) {
|
||||
metrics.addBlockReport((int) (endTime - startTime));
|
||||
}
|
||||
blockLog.info("BLOCK* processReport: from storage {} node {}, " +
|
||||
blockLog.info("BLOCK* processReport 0x{}: from storage {} node {}, " +
|
||||
"blocks: {}, hasStaleStorage: {}, processing time: {} msecs, " +
|
||||
"invalidatedBlocks: {}", storage.getStorageID(), nodeID,
|
||||
newReport.getNumberOfBlocks(),
|
||||
"invalidatedBlocks: {}", strBlockReportId, storage.getStorageID(),
|
||||
nodeID, newReport.getNumberOfBlocks(),
|
||||
node.hasStaleStorages(), (endTime - startTime),
|
||||
invalidatedBlocks.size());
|
||||
return !node.hasStaleStorages();
|
||||
|
@ -2108,7 +2113,8 @@ public class BlockManager implements BlockStatsMXBean {
|
|||
|
||||
private Collection<Block> processReport(
|
||||
final DatanodeStorageInfo storageInfo,
|
||||
final BlockListAsLongs report) throws IOException {
|
||||
final BlockListAsLongs report,
|
||||
BlockReportContext context) throws IOException {
|
||||
// Normal case:
|
||||
// Modify the (block-->datanode) map, according to the difference
|
||||
// between the old and new block report.
|
||||
|
@ -2121,6 +2127,11 @@ public class BlockManager implements BlockStatsMXBean {
|
|||
reportDiff(storageInfo, report,
|
||||
toAdd, toRemove, toInvalidate, toCorrupt, toUC);
|
||||
|
||||
String strBlockReportId = "";
|
||||
if (context != null) {
|
||||
strBlockReportId = Long.toHexString(context.getReportId());
|
||||
}
|
||||
|
||||
DatanodeDescriptor node = storageInfo.getDatanodeDescriptor();
|
||||
// Process the blocks on each queue
|
||||
for (StatefulBlockInfo b : toUC) {
|
||||
|
@ -2135,8 +2146,8 @@ public class BlockManager implements BlockStatsMXBean {
|
|||
numBlocksLogged++;
|
||||
}
|
||||
if (numBlocksLogged > maxNumBlocksToLog) {
|
||||
blockLog.info("BLOCK* processReport: logged info for {} of {} " +
|
||||
"reported.", maxNumBlocksToLog, numBlocksLogged);
|
||||
blockLog.info("BLOCK* processReport 0x{}: logged info for {} of {} " +
|
||||
"reported.", strBlockReportId, maxNumBlocksToLog, numBlocksLogged);
|
||||
}
|
||||
for (Block b : toInvalidate) {
|
||||
addToInvalidates(b, node);
|
||||
|
|
Loading…
Reference in New Issue