HDFS-3682. MiniDFSCluster#init should provide more info when it fails. Contributed by Todd Lipcon
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/branch-2@1395386 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
parent
029f68bd96
commit
d61d75abe5
|
@ -37,6 +37,9 @@ Release 2.0.3-alpha - Unreleased
|
|||
HDFS-3483. Better error message when hdfs fsck is run against a ViewFS
|
||||
config. (Stephen Fritz via atm)
|
||||
|
||||
HDFS-3682. MiniDFSCluster#init should provide more info when it fails.
|
||||
(todd via eli)
|
||||
|
||||
OPTIMIZATIONS
|
||||
|
||||
BUG FIXES
|
||||
|
|
|
@ -622,14 +622,20 @@ public class MiniDFSCluster {
|
|||
}
|
||||
|
||||
federation = nnTopology.isFederated();
|
||||
createNameNodesAndSetConf(
|
||||
nnTopology, manageNameDfsDirs, manageNameDfsSharedDirs,
|
||||
enableManagedDfsDirsRedundancy,
|
||||
format, operation, clusterId, conf);
|
||||
|
||||
try {
|
||||
createNameNodesAndSetConf(
|
||||
nnTopology, manageNameDfsDirs, manageNameDfsSharedDirs,
|
||||
enableManagedDfsDirsRedundancy,
|
||||
format, operation, clusterId, conf);
|
||||
} catch (IOException ioe) {
|
||||
LOG.error("IOE creating namenodes. Permissions dump:\n" +
|
||||
createPermissionsDiagnosisString(data_dir));
|
||||
throw ioe;
|
||||
}
|
||||
if (format) {
|
||||
if (data_dir.exists() && !FileUtil.fullyDelete(data_dir)) {
|
||||
throw new IOException("Cannot remove data directory: " + data_dir);
|
||||
throw new IOException("Cannot remove data directory: " + data_dir +
|
||||
createPermissionsDiagnosisString(data_dir));
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -645,6 +651,27 @@ public class MiniDFSCluster {
|
|||
ProxyUsers.refreshSuperUserGroupsConfiguration(conf);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return a debug string which can help diagnose an error of why
|
||||
* a given directory might have a permissions error in the context
|
||||
* of a test case
|
||||
*/
|
||||
private String createPermissionsDiagnosisString(File path) {
|
||||
StringBuilder sb = new StringBuilder();
|
||||
while (path != null) {
|
||||
sb.append("path '" + path + "': ").append("\n");
|
||||
sb.append("\tabsolute:").append(path.getAbsolutePath()).append("\n");
|
||||
sb.append("\tpermissions: ");
|
||||
sb.append(path.isDirectory() ? "d": "-");
|
||||
sb.append(path.canRead() ? "r" : "-");
|
||||
sb.append(path.canWrite() ? "w" : "-");
|
||||
sb.append(path.canExecute() ? "x" : "-");
|
||||
sb.append("\n");
|
||||
path = path.getParentFile();
|
||||
}
|
||||
return sb.toString();
|
||||
}
|
||||
|
||||
private void createNameNodesAndSetConf(MiniDFSNNTopology nnTopology,
|
||||
boolean manageNameDfsDirs, boolean manageNameDfsSharedDirs,
|
||||
boolean enableManagedDfsDirsRedundancy, boolean format,
|
||||
|
|
Loading…
Reference in New Issue