From d6e5e4288ca35902a2257fa3862b5e1342903cad Mon Sep 17 00:00:00 2001 From: Brahma Reddy Battula Date: Sat, 31 Dec 2016 16:16:02 +0530 Subject: [PATCH] HADOOP-13883. Addendum patch to correct the message and alphabetized with the earlier patch. Contributed by Yiqun Lin. (cherry picked from commit 6938b677111a5fa6bf654717b310220f98b7cf20) --- .../apache/hadoop/util/GenericOptionsParser.java | 14 ++++++++------ .../src/site/markdown/CommandsManual.md | 2 +- .../hadoop/mapred/pipes/TestPipeApplication.java | 4 +++- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java index 04e8024d54f..f01bcbb6dc6 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java @@ -212,10 +212,11 @@ public CommandLine getCommandLine() { */ @SuppressWarnings("static-access") private static synchronized Options buildGeneralOptions(Options opts) { - Option fs = OptionBuilder.withArgName("local|namenode:port") - .hasArg() - .withDescription("specify a namenode") - .create("fs"); + Option fs = OptionBuilder.withArgName("file:///|hdfs://namenode:port") + .hasArg() + .withDescription("specify default filesystem URL to use, " + + "overrides 'fs.defaultFS' property from configurations.") + .create("fs"); Option jt = OptionBuilder.withArgName("local|resourcemanager:port") .hasArg() .withDescription("specify a ResourceManager") @@ -569,8 +570,9 @@ public static void printGenericCommandUsage(PrintStream out) { + "specify an application configuration file"); out.println("-D " + "define a value for a given property"); - out.println("-fs " - + "specify a namenode"); + out.println("-fs " + + "specify default filesystem URL to use, overrides " + + "'fs.defaultFS' property from configurations."); out.println("-jt " + "specify a ResourceManager"); out.println("-files " diff --git a/hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md b/hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md index cf6521e8f84..03dccb956c1 100644 --- a/hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md +++ b/hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md @@ -39,11 +39,11 @@ Many subcommands honor a common set of configuration options to alter their beha | GENERIC\_OPTION | Description | |:---- |:---- | -| `-fs or ` | Specify a NameNode. | | `-archives ` | Specify comma separated archives to be unarchived on the compute machines. Applies only to job. | | `-conf ` | Specify an application configuration file. | | `-D = ` | Use value for given property. | | `-files ` | Specify comma separated files to be copied to the map reduce cluster. Applies only to job. | +| `-fs or ` | Specify default filesystem URL to use. Overrides 'fs.defaultFS' property from configurations. | | `-jt or ` | Specify a ResourceManager. Applies only to job. | | `-libjars ` | Specify comma separated jar files to include in the classpath. Applies only to job. | diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/pipes/TestPipeApplication.java b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/pipes/TestPipeApplication.java index 5fbce5d4c9d..9b88c5c4ee2 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/pipes/TestPipeApplication.java +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/pipes/TestPipeApplication.java @@ -306,7 +306,9 @@ public void testSubmitter() throws Exception { "-D define a value for a given " + "property")); assertTrue(out.toString() - .contains("-fs specify a namenode")); + .contains("-fs " + + "specify default filesystem URL to use, overrides " + + "'fs.defaultFS' property from configurations.")); assertTrue(out.toString().contains( "-jt specify a ResourceManager")); assertTrue(out.toString().contains(