diff --git a/hadoop-yarn-project/CHANGES.txt b/hadoop-yarn-project/CHANGES.txt index 288cb5078ab..18f914bc3c4 100644 --- a/hadoop-yarn-project/CHANGES.txt +++ b/hadoop-yarn-project/CHANGES.txt @@ -70,6 +70,9 @@ Release 2.4.0 - UNRELEASED YARN-1630. Introduce timeout for async polling operations in YarnClientImpl (Aditya Acharya via Sandy Ryza) + YARN-1617. Remove ancient comment and surround LOG.debug in + AppSchedulingInfo.allocate (Sandy Ryza) + OPTIMIZATIONS BUG FIXES diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java index 7ac1c0a6714..3270dea4498 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java @@ -262,8 +262,13 @@ public class AppSchedulingInfo { pending = false; metrics.runAppAttempt(applicationId, user); } - LOG.debug("allocate: user: " + user + ", memory: " - + request.getCapability()); + if (LOG.isDebugEnabled()) { + LOG.debug("allocate: applicationId=" + applicationId + + " container=" + container.getId() + + " host=" + container.getNodeId().toString() + + " user=" + user + + " resource=" + request.getCapability()); + } metrics.allocateResources(user, 1, request.getCapability()); } @@ -277,9 +282,6 @@ public class AppSchedulingInfo { synchronized private void allocateNodeLocal( SchedulerNode node, Priority priority, ResourceRequest nodeLocalRequest, Container container) { - // Update consumption and track allocations - allocate(container); - // Update future requirements nodeLocalRequest.setNumContainers(nodeLocalRequest.getNumContainers() - 1); if (nodeLocalRequest.getNumContainers() == 0) { @@ -306,10 +308,6 @@ public class AppSchedulingInfo { synchronized private void allocateRackLocal( SchedulerNode node, Priority priority, ResourceRequest rackLocalRequest, Container container) { - - // Update consumption and track allocations - allocate(container); - // Update future requirements rackLocalRequest.setNumContainers(rackLocalRequest.getNumContainers() - 1); if (rackLocalRequest.getNumContainers() == 0) { @@ -329,10 +327,6 @@ public class AppSchedulingInfo { synchronized private void allocateOffSwitch( SchedulerNode node, Priority priority, ResourceRequest offSwitchRequest, Container container) { - - // Update consumption and track allocations - allocate(container); - // Update future requirements decrementOutstanding(offSwitchRequest); } @@ -365,20 +359,6 @@ public class AppSchedulingInfo { } } - synchronized private void allocate(Container container) { - // Update consumption and track allocations - //TODO: fixme sharad - /* try { - store.storeContainer(container); - } catch (IOException ie) { - // TODO fix this. we shouldnt ignore - }*/ - - LOG.debug("allocate: applicationId=" + applicationId + " container=" - + container.getId() + " host=" - + container.getNodeId().toString()); - } - synchronized public void stop(RMAppAttemptState rmAppAttemptFinalState) { // clear pending resources metrics for the application QueueMetrics metrics = queue.getMetrics();