diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index 1148b58fdc1..27bae6672ac 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -926,6 +926,9 @@ Release 2.7.3 - UNRELEASED HADOOP-12602. TestMetricsSystemImpl#testQSize occasionally fails. (Masatake Iwasaki via aajisaka) + HADOOP-12588. Fix intermittent test failure of TestGangliaMetrics. + (Masatake Iwasaki via aajisaka) + Release 2.7.2 - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestGangliaMetrics.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestGangliaMetrics.java index e097a0f8738..c386e362610 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestGangliaMetrics.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestGangliaMetrics.java @@ -29,7 +29,9 @@ import java.util.ArrayList; import java.util.HashSet; import java.util.List; import java.util.Set; +import java.util.concurrent.CopyOnWriteArrayList; +import org.apache.commons.io.Charsets; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.apache.hadoop.metrics2.AbstractMetric; @@ -145,7 +147,7 @@ public class TestGangliaMetrics { private void checkMetrics(List bytearrlist, int expectedCount) { boolean[] foundMetrics = new boolean[expectedMetrics.length]; for (byte[] bytes : bytearrlist) { - String binaryStr = new String(bytes); + String binaryStr = new String(bytes, Charsets.UTF_8); for (int index = 0; index < expectedMetrics.length; index++) { if (binaryStr.indexOf(expectedMetrics[index]) >= 0) { foundMetrics[index] = true; @@ -188,13 +190,13 @@ public class TestGangliaMetrics { * hence all the captured byte arrays were pointing to one instance. */ private class MockDatagramSocket extends DatagramSocket { - private ArrayList capture; + private List capture; /** * @throws SocketException */ public MockDatagramSocket() throws SocketException { - capture = new ArrayList(); + capture = new CopyOnWriteArrayList(); } /* (non-Javadoc) @@ -211,7 +213,7 @@ public class TestGangliaMetrics { /** * @return the captured byte arrays */ - ArrayList getCapturedSend() { + List getCapturedSend() { return capture; } }