From e519df47b27cae68e2105aa46ee9486891163ab7 Mon Sep 17 00:00:00 2001 From: Arpit Agarwal Date: Wed, 8 Jul 2015 09:31:02 -0700 Subject: [PATCH] HDFS-8642. Make TestFileTruncate more reliable. (Contributed by Rakesh R) --- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 +++ .../hdfs/server/namenode/TestFileTruncate.java | 18 ++++++------------ 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index 3d1caabf8c2..c6bcb0fc44b 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -681,6 +681,9 @@ Release 2.8.0 - UNRELEASED HDFS-8686. WebHdfsFileSystem#getXAttr(Path p, final String name) doesn't work if namespace is in capitals (kanaka kumar avvaru via vinayakumarb) + HDFS-8642. Make TestFileTruncate more reliable. (Rakesh R via + Arpit Agarwal) + Release 2.7.2 - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java index e0f9ad20ee0..a91d6c91ccd 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java @@ -62,9 +62,8 @@ import org.apache.hadoop.test.GenericTestUtils; import org.apache.hadoop.util.Time; import org.apache.hadoop.util.ToolRunner; import org.apache.log4j.Level; -import org.junit.AfterClass; +import org.junit.After; import org.junit.Before; -import org.junit.BeforeClass; import org.junit.Test; public class TestFileTruncate { @@ -90,8 +89,8 @@ public class TestFileTruncate { private Path parent; - @BeforeClass - public static void startUp() throws IOException { + @Before + public void setUp() throws IOException { conf = new HdfsConfiguration(); conf.setLong(DFSConfigKeys.DFS_NAMENODE_MIN_BLOCK_SIZE_KEY, BLOCK_SIZE); conf.setInt(DFSConfigKeys.DFS_BYTES_PER_CHECKSUM_KEY, BLOCK_SIZE); @@ -105,20 +104,15 @@ public class TestFileTruncate { .waitSafeMode(true) .build(); fs = cluster.getFileSystem(); + parent = new Path("/test"); } - @AfterClass - public static void tearDown() throws IOException { + @After + public void tearDown() throws IOException { if(fs != null) fs.close(); if(cluster != null) cluster.shutdown(); } - @Before - public void setup() throws IOException { - parent = new Path("/test"); - fs.delete(parent, true); - } - /** * Truncate files of different sizes byte by byte. */